From 9e00ef0849d99f95bdd273152946f0b1dea41757 Mon Sep 17 00:00:00 2001 From: Simon Wanner Date: Mon, 20 Mar 2023 23:49:27 +0100 Subject: [PATCH] LibWeb: Pass scope in ParentNode::query_selector_all --- Userland/Libraries/LibWeb/DOM/ParentNode.cpp | 11 ++++++++++- 1 file changed, 10 insertions(+), 1 deletion(-) diff --git a/Userland/Libraries/LibWeb/DOM/ParentNode.cpp b/Userland/Libraries/LibWeb/DOM/ParentNode.cpp index 1f4bbb9104..f32a80e4df 100644 --- a/Userland/Libraries/LibWeb/DOM/ParentNode.cpp +++ b/Userland/Libraries/LibWeb/DOM/ParentNode.cpp @@ -50,19 +50,28 @@ WebIDL::ExceptionOr> ParentNode::query_selector(StringView se return result; } +// https://dom.spec.whatwg.org/#dom-parentnode-queryselectorall WebIDL::ExceptionOr> ParentNode::query_selector_all(StringView selector_text) { + // The querySelectorAll(selectors) method steps are to return the static result of running scope-match a selectors string selectors against this. + + // https://dom.spec.whatwg.org/#scope-match-a-selectors-string + // To scope-match a selectors string selectors against a node, run these steps: + // 1. Let s be the result of parse a selector selectors. auto maybe_selectors = parse_selector(CSS::Parser::ParsingContext(*this), selector_text); + + // 2. If s is failure, then throw a "SyntaxError" DOMException. if (!maybe_selectors.has_value()) return WebIDL::SyntaxError::create(realm(), "Failed to parse selector"); auto selectors = maybe_selectors.value(); + // 3. Return the result of match a selector against a tree with s and node’s root using scoping root node. Vector> elements; // FIXME: This should be shadow-including. https://drafts.csswg.org/selectors-4/#match-a-selector-against-a-tree for_each_in_subtree_of_type([&](auto& element) { for (auto& selector : selectors) { - if (SelectorEngine::matches(selector, element)) { + if (SelectorEngine::matches(selector, element, {}, this)) { elements.append(&element); } }