1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-25 19:47:44 +00:00

LibJS: Fix \x escapes of bytes with high bit set

With this, typing `"\xff"` into Browser's console no longer
makes the app crash.

While here, also make the \u handler call append_codepoint()
instead of calling an overload where it's not immediately clear
which overload is getting called. This has no behavior change.
This commit is contained in:
Nico Weber 2020-07-22 12:54:50 -04:00 committed by Andreas Kling
parent 01522b8d71
commit 9e32ad6c99
2 changed files with 4 additions and 2 deletions

View file

@ -3,6 +3,7 @@ test("hex escapes", () => {
expect("X55").toBe("X55");
expect(`\x55`).toBe("U");
expect(`\X55`).toBe("X55");
expect("\xff").toBe(String.fromCharCode(0xff));
});
test("unicode escapes", () => {
@ -10,4 +11,5 @@ test("unicode escapes", () => {
expect(`\u26a0`).toBe("⚠");
expect("\u{1f41e}").toBe("🐞");
expect(`\u{1f41e}`).toBe("🐞");
expect("\u00ff").toBe(String.fromCharCode(0xff));
});