RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-05-31 07:48:11 +00:00
Code Issues Activity Actions

LibJS/Bytecode: Use malloc instead of mmap for BasicBlock buffers

Browse source 
Using mmap was quite punishing on inputs with lots of basic blocks,
such as test262 tests with eval() in a loop that goes 64k times..

~27% speed-up on language/literals/regexp/S7.8.5_A2.1_T2.js but
presumably everything everywhere will benefit from this. :^)
This commit is contained in:
Andreas Kling 2023-07-13 09:48:05 +02:00
parent ce6138fccd
commit 9e468579ce
1 changed files with 2 additions and 4 deletions
Download patch file Download diff file Expand all files Collapse all files

6
Userland/Libraries/LibJS/Bytecode/BasicBlock.cpp
View file

@ -7,7 +7,6 @@
#include <AK/DeprecatedString.h>
#include <LibJS/Bytecode/BasicBlock.h>
#include <LibJS/Bytecode/Op.h>
#include <sys/mman.h>
namespace JS::Bytecode {
@ -23,8 +22,7 @@ BasicBlock::BasicBlock(DeprecatedString name, size_t size)
// The main issue we're working around here is that we don't want pointers into the bytecode stream to become invalidated
// during code generation due to dynamic buffer resizing. Otherwise we could just use a Vector.
m_buffer_capacity = size;
m_buffer = (u8*)mmap(nullptr, m_buffer_capacity, PROT_READ | PROT_WRITE, MAP_ANONYMOUS | MAP_PRIVATE, -1, 0);
VERIFY(m_buffer != MAP_FAILED);
m_buffer = new u8[m_buffer_capacity];
}
BasicBlock::~BasicBlock()
@ -36,7 +34,7 @@ BasicBlock::~BasicBlock()
Instruction::destroy(const_cast<Instruction&>(to_destroy));
}
munmap(m_buffer, m_buffer_capacity);
delete[] m_buffer;
}
void BasicBlock::seal()