RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-26 21:47:46 +00:00
Code Issues Activity Actions

LibCore: Make get_password return SecretString instead of String

Browse source 
We shouldn't let secrets sit around in memory, as they could potentially
be retrieved by an attacker, or left in memory during a core dump.
This commit is contained in:
Brian Gianforcaro 2021-09-11 09:53:25 -07:00 • committed by Andreas Kling
parent 3bf6902790
commit 9e667453c7
6 changed files with 12 additions and 10 deletions
Download patch file Download diff file Expand all files Collapse all files

6
Userland/Libraries/LibCore/GetPassword.cpp
View file

@ -13,7 +13,7 @@
namespace Core {
Result<String, OSError> get_password(const StringView& prompt)
Result<SecretString, OSError> get_password(const StringView& prompt)
{
if (write(STDOUT_FILENO, prompt.characters_without_null_termination(), prompt.length()) < 0)
return OSError(errno);
@ -44,8 +44,6 @@ Result<String, OSError> get_password(const StringView& prompt)
// Remove trailing '\n' read by getline().
password[line_length - 1] = '\0';
String s(password);
free(password);
return s;
return SecretString::take_ownership(password, line_length);
}
}