mirror of
https://github.com/RGBCube/serenity
synced 2025-07-27 06:07:34 +00:00
LibCore: Make get_password return SecretString instead of String
We shouldn't let secrets sit around in memory, as they could potentially be retrieved by an attacker, or left in memory during a core dump.
This commit is contained in:
parent
3bf6902790
commit
9e667453c7
6 changed files with 12 additions and 10 deletions
|
@ -13,7 +13,7 @@
|
|||
|
||||
namespace Core {
|
||||
|
||||
Result<String, OSError> get_password(const StringView& prompt)
|
||||
Result<SecretString, OSError> get_password(const StringView& prompt)
|
||||
{
|
||||
if (write(STDOUT_FILENO, prompt.characters_without_null_termination(), prompt.length()) < 0)
|
||||
return OSError(errno);
|
||||
|
@ -44,8 +44,6 @@ Result<String, OSError> get_password(const StringView& prompt)
|
|||
// Remove trailing '\n' read by getline().
|
||||
password[line_length - 1] = '\0';
|
||||
|
||||
String s(password);
|
||||
free(password);
|
||||
return s;
|
||||
return SecretString::take_ownership(password, line_length);
|
||||
}
|
||||
}
|
||||
|
|
Loading…
Add table
Add a link
Reference in a new issue