RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-28 01:57:35 +00:00
Code Issues Activity Actions

LibCore: Make get_password return SecretString instead of String

Browse source 
We shouldn't let secrets sit around in memory, as they could potentially
be retrieved by an attacker, or left in memory during a core dump.
This commit is contained in:
Brian Gianforcaro 2021-09-11 09:53:25 -07:00 • committed by Andreas Kling
parent 3bf6902790
commit 9e667453c7
6 changed files with 12 additions and 10 deletions
Download patch file Download diff file Expand all files Collapse all files

3
Userland/Libraries/LibCore/GetPassword.h
View file

@ -9,9 +9,10 @@
#include <AK/OSError.h>
#include <AK/Result.h>
#include <AK/String.h>
#include <LibCore/SecretString.h>
namespace Core {
Result<String, OSError> get_password(const StringView& prompt = "Password: ");
Result<SecretString, OSError> get_password(const StringView& prompt = "Password: "sv);
}