RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-05-31 00:48:11 +00:00
Code Issues Activity Actions

LibJS: Return -Infinity in Math.max() with no argument

Browse source
This commit is contained in:
Linus Groh 2020-04-05 17:09:18 +01:00 • committed by Andreas Kling
parent 8bfee015bc
commit 9e7dcaa106
2 changed files with 2 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

3
Libraries/LibJS/Runtime/MathObject.cpp
View file

@ -126,8 +126,7 @@ Value MathObject::round(Interpreter& interpreter)
Value MathObject::max(Interpreter& interpreter) Value MathObject::max(Interpreter& interpreter)
{ {
if (!interpreter.argument_count()) { if (!interpreter.argument_count()) {
// FIXME: I think this should return *negative* infinity. return Value(-js_infinity().as_double());
return js_infinity();
} else if (interpreter.argument_count() == 1) { } else if (interpreter.argument_count() == 1) {
return interpreter.argument(0).to_number(); return interpreter.argument(0).to_number();
} else { } else {

1
Libraries/LibJS/Tests/Math.max.js
View file

@ -1,5 +1,6 @@
try { try {
assert(Math.max.length === 2); assert(Math.max.length === 2);
assert(Math.max() === -Infinity);
assert(Math.max(1) === 1); assert(Math.max(1) === 1);
assert(Math.max(2, 1) === 2); assert(Math.max(2, 1) === 2);
assert(Math.max(1, 2, 3) === 3); assert(Math.max(1, 2, 3) === 3);