RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-27 06:27:45 +00:00
Code Issues Activity Actions

LibJS: Implement Temporal.PlainDateTime.compare()

Browse source
This commit is contained in:
Idan Horowitz 2021-08-27 16:42:21 +03:00 • committed by Linus Groh
parent 28fa4d1568
commit 9ed877e8e7
3 changed files with 32 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

18
Userland/Libraries/LibJS/Runtime/Temporal/PlainDateTimeConstructor.cpp
View file

@ -31,6 +31,7 @@ void PlainDateTimeConstructor::initialize(GlobalObject& global_object)
u8 attr = Attribute::Writable | Attribute::Configurable; u8 attr = Attribute::Writable | Attribute::Configurable;
define_native_function(vm.names.from, from, 1, attr); define_native_function(vm.names.from, from, 1, attr);
define_native_function(vm.names.compare, compare, 2, attr);
define_direct_property(vm.names.length, Value(3), Attribute::Configurable); define_direct_property(vm.names.length, Value(3), Attribute::Configurable);
} }
@ -141,4 +142,21 @@ JS_DEFINE_NATIVE_FUNCTION(PlainDateTimeConstructor::from)
return to_temporal_date_time(global_object, item, options); return to_temporal_date_time(global_object, item, options);
} }
// 5.2.3 Temporal.PlainDateTime.compare ( one, two ), https://tc39.es/proposal-temporal/#sec-temporal.plaindatetime.compare
JS_DEFINE_NATIVE_FUNCTION(PlainDateTimeConstructor::compare)
{
// 1. Set one to ? ToTemporalDateTime(one).
auto* one = to_temporal_date_time(global_object, vm.argument(0));
if (vm.exception())
return {};
// 2. Set two to ? ToTemporalDateTime(two).
auto two = to_temporal_date_time(global_object, vm.argument(1));
if (vm.exception())
return {};
// 3. Return 𝔽(! CompareISODateTime(one.[[ISOYear]], one.[[ISOMonth]], one.[[ISODay]], one.[[ISOHour]], one.[[ISOMinute]], one.[[ISOSecond]], one.[[ISOMillisecond]], one.[[ISOMicrosecond]], one.[[ISONanosecond]], two.[[ISOYear]], two.[[ISOMonth]], two.[[ISODay]], two.[[ISOHour]], two.[[ISOMinute]], two.[[ISOSecond]], two.[[ISOMillisecond]], two.[[ISOMicrosecond]], two.[[ISONanosecond]])).
return Value(compare_iso_date_time(one->iso_year(), one->iso_month(), one->iso_day(), one->iso_hour(), one->iso_minute(), one->iso_second(), one->iso_millisecond(), one->iso_microsecond(), one->iso_nanosecond(), two->iso_year(), two->iso_month(), two->iso_day(), two->iso_hour(), two->iso_minute(), two->iso_second(), two->iso_millisecond(), two->iso_microsecond(), two->iso_nanosecond()));
}
} }

1
Userland/Libraries/LibJS/Runtime/Temporal/PlainDateTimeConstructor.h
View file

@ -25,6 +25,7 @@ private:
virtual bool has_constructor() const override { return true; } virtual bool has_constructor() const override { return true; }
JS_DECLARE_NATIVE_FUNCTION(from); JS_DECLARE_NATIVE_FUNCTION(from);
JS_DECLARE_NATIVE_FUNCTION(compare);
}; };
} }

13
Userland/Libraries/LibJS/Tests/builtins/Temporal/PlainDateTime/PlainDateTime.compare.js Normal file
View file

@ -0,0 +1,13 @@
describe("correct behavior", () => {
test("length is 2", () => {
expect(Temporal.PlainDateTime.compare).toHaveLength(2);
});
test("basic functionality", () => {
const plainDateTime1 = new Temporal.PlainDateTime(2021, 8, 27, 16, 38, 40, 1, 2, 3);
expect(Temporal.PlainDateTime.compare(plainDateTime1, plainDateTime1)).toBe(0);
const plainDateTime2 = new Temporal.PlainDateTime(2021, 8, 27, 16, 39, 5, 0, 1, 2);
expect(Temporal.PlainDateTime.compare(plainDateTime1, plainDateTime2)).toBe(-1);
expect(Temporal.PlainDateTime.compare(plainDateTime2, plainDateTime1)).toBe(1);
});
});