From 9efd80f1008c4b67339a9cdb86fdac69ac96b47a Mon Sep 17 00:00:00 2001 From: Andreas Kling Date: Mon, 15 Feb 2021 11:51:08 +0100 Subject: [PATCH] LibJS: Use fabs() instead of abs() in JS::Value abs() takes an int, so this would only work correctly for numbers smaller than INT_MAX. --- Userland/Libraries/LibJS/Runtime/Value.cpp | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/Userland/Libraries/LibJS/Runtime/Value.cpp b/Userland/Libraries/LibJS/Runtime/Value.cpp index deccdf7c99..756ff44b2d 100644 --- a/Userland/Libraries/LibJS/Runtime/Value.cpp +++ b/Userland/Libraries/LibJS/Runtime/Value.cpp @@ -191,7 +191,7 @@ static String double_to_string(double d) else builder.append('-'); - builder.append(String::format("%d", abs(exponent - 1))); + builder.append(String::number(fabs(exponent - 1))); return builder.to_string(); } @@ -205,7 +205,7 @@ static String double_to_string(double d) else builder.append('-'); - builder.append(String::format("%d", abs(exponent - 1))); + builder.append(String::number(fabs(exponent - 1))); return builder.to_string(); } @@ -576,7 +576,7 @@ double Value::to_integer_or_infinity(GlobalObject& global_object) const return 0; if (number.is_infinity()) return number.as_double(); - auto integer = floor(abs(number.as_double())); + auto integer = floor(fabs(number.as_double())); if (number.as_double() < 0) integer = -integer; return integer;