RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-05-31 03:18:11 +00:00
Code Issues Activity Actions

LibJS: Report correct line/column for string literal syntax errors

Browse source 
We're passing a token to this function, so m_current_token is actually
the next token - which leads to incorrect line/column numbers for string
literal syntax errors:

    "\u"
        ^
    Uncaught exception: [SyntaxError]: Malformed unicode escape sequence (line: 1, column: 5)

Rather than:

    "\u"
    ^
    Uncaught exception: [SyntaxError]: Malformed unicode escape sequence (line: 1, column: 1)
This commit is contained in:
Linus Groh 2020-10-24 12:48:25 +01:00 • committed by Andreas Kling
parent d6f8c52245
commit 9f036959e8
1 changed files with 2 additions and 4 deletions
Download patch file Download diff file Expand all files Collapse all files

6
Libraries/LibJS/Parser.cpp
View file

@ -849,10 +849,8 @@ NonnullRefPtr<StringLiteral> Parser::parse_string_literal(Token token)
message = "Unicode code_point must not be greater than 0x10ffff in escape sequence"; message = "Unicode code_point must not be greater than 0x10ffff in escape sequence";
} }
syntax_error( if (!message.is_empty())
message, syntax_error(message, token.line_number(), token.line_column());
m_parser_state.m_current_token.line_number(),
m_parser_state.m_current_token.line_column());
} }
if (m_parser_state.m_use_strict_directive == UseStrictDirectiveState::Looking) { if (m_parser_state.m_use_strict_directive == UseStrictDirectiveState::Looking) {