RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-27 09:27:35 +00:00
Code Issues Activity Actions

LibWeb: Use width & height to create fallback viewBox for SVG-as-image

Browse source 
When embedding an SVG in an img element, if the external SVG's root
element has both width and height attributes, but no viewBox attribute,
we now create a fallback viewBox with "0 0 width height".

This appears to match the behavior of other browsers. Inspired by
discussion on Mozilla's bug tracker:
https://bugzilla.mozilla.org/show_bug.cgi?id=614649
This commit is contained in:
Andreas Kling 2023-06-20 09:39:14 +02:00
parent a0b4987e92
commit 9f24c1b34c
6 changed files with 66 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

1
Tests/LibWeb/Layout/input/svg/svg-as-image-implicit-viewbox.html Normal file
View file

@ -0,0 +1 @@
<!doctype html><img src="svg-without-viewbox.svg" style="display: block; width: 50px;">

1
Tests/LibWeb/Layout/input/svg/svg-without-viewbox.svg Normal file
View file

@ -0,0 +1 @@
<svg width="100" height="200" xmlns="http://www.w3.org/2000/svg"><rect x="0" y="0" width="100" height="200" fill="green" /></svg>
Side by side

After

Width:  |  Height:  |  Size: 129 B