RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-25 05:37:43 +00:00
Code Issues Activity Actions

WebServer: Fix jailbreaking of server via .. relative paths

Browse source 
The recent patch to LexicalPath allowed relative paths like ../ to work
in requests to WebServer. This wasn't too dangerous because of unveil,
but let's still fix this :^)
This commit is contained in:
DexesTTP 2021-05-18 08:58:37 +02:00 • committed by Andreas Kling
parent 7957f13e98
commit 9f42ccd639
1 changed files with 1 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

2
Userland/Services/WebServer/Client.cpp
View file

@ -73,7 +73,7 @@ void Client::handle_request(ReadonlyBytes raw_request)
return;
}
auto requested_path = LexicalPath::canonicalized_path(request.resource());
auto requested_path = LexicalPath::join("/", request.resource()).string();
dbgln("Canonical requested path: '{}'", requested_path);
StringBuilder path_builder;