From 9f50e288f7f558061f98dc41c4655b9a9731ba66 Mon Sep 17 00:00:00 2001 From: Brian Gianforcaro Date: Thu, 16 Sep 2021 01:53:24 -0700 Subject: [PATCH] LibJS: Fix Clang Toolchain CI build Clang was failing because because it rightfully saw we were attempting to call a deleted constructor of `MarkedValueList`. If you explicitly called move(list) then GCC would complain that the move was unnecessary. For what ever reason both tool chains accept when we construct the ThrowCompletionOr explicitly that we move the list into and return that. --- Userland/Libraries/LibJS/Runtime/AbstractOperations.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Userland/Libraries/LibJS/Runtime/AbstractOperations.cpp b/Userland/Libraries/LibJS/Runtime/AbstractOperations.cpp index 2d0effb398..bf304a95b8 100644 --- a/Userland/Libraries/LibJS/Runtime/AbstractOperations.cpp +++ b/Userland/Libraries/LibJS/Runtime/AbstractOperations.cpp @@ -93,7 +93,7 @@ ThrowCompletionOr create_list_from_array_like(GlobalObject& glo } // 7. Return list. - return list; + return ThrowCompletionOr(move(list)); } // 7.3.22 SpeciesConstructor ( O, defaultConstructor ), https://tc39.es/ecma262/#sec-speciesconstructor