RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-26 08:47:34 +00:00
Code Issues Activity Actions

Piano: Clean up code style with help from clang-tidy

Browse source 
Includes shadowed variables and if-else return.
This commit is contained in:
kleines Filmröllchen 2023-02-09 13:36:10 +01:00 • committed by Andrew Kaster
parent 401a21e4f4
commit 9f5f6b3868
4 changed files with 5 additions and 8 deletions
Download patch file Download diff file Expand all files Collapse all files

3
Userland/Applications/Piano/KeysWidget.cpp
View file

@ -23,8 +23,7 @@ int KeysWidget::mouse_note() const
{
if (m_mouse_down && m_mouse_note + m_keyboard->virtual_keyboard_octave_base() < note_count)
return m_mouse_note; // Can be -1.
else
return -1;
return -1;
}
void KeysWidget::set_key(i8 key, DSP::Keyboard::Switch switch_note)

3
Userland/Applications/Piano/MainWidget.cpp
View file

@ -94,8 +94,7 @@ void MainWidget::keydown_event(GUI::KeyEvent& event)
// This is to stop held-down keys from creating multiple events.
if (m_keys_pressed[event.key()])
return;
else
m_keys_pressed[event.key()] = true;
m_keys_pressed[event.key()] = true;
bool event_was_accepted = false;
if (note_key_action(event.key(), DSP::Keyboard::Switch::On))

4
Userland/Applications/Piano/ProcessorParameterWidget/Slider.cpp
View file

@ -30,12 +30,12 @@ ProcessorParameterSlider::ProcessorParameterSlider(Orientation orientation, DSP:
if (m_value_label != nullptr)
m_value_label->set_text(DeprecatedString::formatted("{:.2f}", static_cast<double>(m_parameter)));
on_change = [this](auto value) {
on_change = [this](auto raw_value) {
if (m_currently_setting_from_ui)
return;
m_currently_setting_from_ui = true;
DSP::ParameterFixedPoint real_value;
real_value.raw() = value;
real_value.raw() = raw_value;
if (is_logarithmic())
// FIXME: Implement exponential for fixed point
real_value = exp2(static_cast<double>(real_value));

3
Userland/Applications/Piano/TrackManager.cpp
View file

@ -74,6 +74,5 @@ int TrackManager::next_track_index() const
auto next_track_index = m_current_track + 1;
if (next_track_index >= m_tracks.size())
return 0;
else
return next_track_index;
return static_cast<int>(next_track_index);
}