RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-05-31 10:08:12 +00:00
Code Issues Activity Actions

LibWeb: Make HTMLMediaElement's attribute change handlers protected

Browse source 
These will be need to be overridden by HTMLVideoElement. We also need to
be sure to invoke HTMLMediaElement's base class's did_remove_attribute.
This commit is contained in:
Timothy Flynn 2023-04-20 06:34:59 -04:00 • committed by Andreas Kling
parent 42d93005ac
commit 9f71799456
2 changed files with 5 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

2
Userland/Libraries/LibWeb/HTML/HTMLMediaElement.cpp
View file

@ -97,6 +97,8 @@ void HTMLMediaElement::parse_attribute(DeprecatedFlyString const& name, Deprecat
void HTMLMediaElement::did_remove_attribute(DeprecatedFlyString const& name) void HTMLMediaElement::did_remove_attribute(DeprecatedFlyString const& name)
{ {
Base::did_remove_attribute(name);
if (name == HTML::AttributeNames::crossorigin) if (name == HTML::AttributeNames::crossorigin)
m_crossorigin = cors_setting_attribute_from_keyword({}); m_crossorigin = cors_setting_attribute_from_keyword({});
} }

6
Userland/Libraries/LibWeb/HTML/HTMLMediaElement.h
View file

@ -81,6 +81,9 @@ protected:
virtual JS::ThrowCompletionOr<void> initialize(JS::Realm&) override; virtual JS::ThrowCompletionOr<void> initialize(JS::Realm&) override;
virtual void visit_edges(Cell::Visitor&) override; virtual void visit_edges(Cell::Visitor&) override;
virtual void parse_attribute(DeprecatedFlyString const& name, DeprecatedString const& value) override;
virtual void did_remove_attribute(DeprecatedFlyString const&) override;
// Override in subclasses to handle implementation-specific behavior when the element state changes // Override in subclasses to handle implementation-specific behavior when the element state changes
// to playing or paused, e.g. to start/stop play timers. // to playing or paused, e.g. to start/stop play timers.
virtual void on_playing() { } virtual void on_playing() { }
@ -94,9 +97,6 @@ private:
struct EntireResource { }; struct EntireResource { };
using ByteRange = Variant<EntireResource>; // FIXME: This will need to include "until end" and an actual byte range. using ByteRange = Variant<EntireResource>; // FIXME: This will need to include "until end" and an actual byte range.
virtual void parse_attribute(DeprecatedFlyString const& name, DeprecatedString const& value) override;
virtual void did_remove_attribute(DeprecatedFlyString const&) override;
Task::Source media_element_event_task_source() const { return m_media_element_event_task_source.source; } Task::Source media_element_event_task_source() const { return m_media_element_event_task_source.source; }
WebIDL::ExceptionOr<void> load_element(); WebIDL::ExceptionOr<void> load_element();