RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-28 04:57:45 +00:00
Code Issues Activity Actions

Meta: Force semi-colon after MAKE_AK_NONXXXABLE()

Browse source 
Before, we had about these occurrence counts:
COPY: 13 without, 33 with
MOVE: 12 without, 28 with

Clearly, 'with' was the preferred way. However, this introduced double-semicolons
all over the place, and caused some warnings to trigger.

This patch *forces* the usage of a semi-colon when calling the macro,
by removing the semi-colon within the macro. (And thus also gets rid
of the double-semicolon.)
This commit is contained in:
Ben Wiederhake 2020-08-26 21:52:24 +02:00 • committed by Andreas Kling
parent 6454969d6b
commit 9f7ec33180
15 changed files with 44 additions and 30 deletions
Download patch file Download diff file Expand all files Collapse all files

5
AK/RefCounted.h
View file

@ -60,8 +60,9 @@ constexpr auto call_one_ref_left_if_present(...) -> FalseType
}
class RefCountedBase {
AK_MAKE_NONCOPYABLE(RefCountedBase)
AK_MAKE_NONMOVABLE(RefCountedBase)
AK_MAKE_NONCOPYABLE(RefCountedBase);
AK_MAKE_NONMOVABLE(RefCountedBase);
public:
typedef unsigned int RefCountType;