RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-27 22:57:44 +00:00
Code Issues Activity Actions

Meta: Force semi-colon after MAKE_AK_NONXXXABLE()

Browse source 
Before, we had about these occurrence counts:
COPY: 13 without, 33 with
MOVE: 12 without, 28 with

Clearly, 'with' was the preferred way. However, this introduced double-semicolons
all over the place, and caused some warnings to trigger.

This patch *forces* the usage of a semi-colon when calling the macro,
by removing the semi-colon within the macro. (And thus also gets rid
of the double-semicolon.)
This commit is contained in:
Ben Wiederhake 2020-08-26 21:52:24 +02:00 • committed by Andreas Kling
parent 6454969d6b
commit 9f7ec33180
15 changed files with 44 additions and 30 deletions
Download patch file Download diff file Expand all files Collapse all files

2
Libraries/LibC/stdlib.cpp
View file

@ -85,7 +85,7 @@ enum DigitConsumeDecision {
template<typename T, T min_value, T max_value>
class NumParser {
AK_MAKE_NONMOVABLE(NumParser)
AK_MAKE_NONMOVABLE(NumParser);
public:
NumParser(Sign sign, int base)

5
Libraries/LibCore/Object.h
View file

@ -62,8 +62,9 @@ class Object
, public Weakable<Object> {
// NOTE: No C_OBJECT macro for Core::Object itself.
AK_MAKE_NONCOPYABLE(Object)
AK_MAKE_NONMOVABLE(Object)
AK_MAKE_NONCOPYABLE(Object);
AK_MAKE_NONMOVABLE(Object);
public:
IntrusiveListNode m_all_objects_list_node;

5
Libraries/LibGUI/Widget.h
View file

@ -68,8 +68,9 @@ enum class VerticalDirection {
};
class WidgetClassRegistration {
AK_MAKE_NONCOPYABLE(WidgetClassRegistration)
AK_MAKE_NONMOVABLE(WidgetClassRegistration)
AK_MAKE_NONCOPYABLE(WidgetClassRegistration);
AK_MAKE_NONMOVABLE(WidgetClassRegistration);
public:
WidgetClassRegistration(const String& class_name, Function<NonnullRefPtr<Widget>()> factory);
~WidgetClassRegistration();

8
Libraries/LibGfx/Bitmap.h
View file

@ -209,13 +209,15 @@ public:
[[nodiscard]] bool set_nonvolatile();
private:
enum class Purgeable { No,
Yes };
enum class Purgeable {
No,
Yes
};
Bitmap(BitmapFormat, const IntSize&, Purgeable);
Bitmap(BitmapFormat, const IntSize&, size_t pitch, RGBA32*);
Bitmap(BitmapFormat, NonnullRefPtr<SharedBuffer>&&, const IntSize&, const Vector<RGBA32>& palette);
void allocate_palette_from_format(BitmapFormat, const Vector<RGBA32>& source_palette );
void allocate_palette_from_format(BitmapFormat, const Vector<RGBA32>& source_palette);
IntSize m_size;
RGBA32* m_data { nullptr };

5
Libraries/LibGfx/Palette.h
View file

@ -36,8 +36,9 @@
namespace Gfx {
class PaletteImpl : public RefCounted<PaletteImpl> {
AK_MAKE_NONCOPYABLE(PaletteImpl)
AK_MAKE_NONMOVABLE(PaletteImpl)
AK_MAKE_NONCOPYABLE(PaletteImpl);
AK_MAKE_NONMOVABLE(PaletteImpl);
public:
~PaletteImpl();
static NonnullRefPtr<PaletteImpl> create_with_shared_buffer(SharedBuffer&);

4
Libraries/LibJS/Runtime/Symbol.h
View file

@ -32,8 +32,8 @@
namespace JS {
class Symbol final : public Cell {
AK_MAKE_NONCOPYABLE(Symbol)
AK_MAKE_NONMOVABLE(Symbol)
AK_MAKE_NONCOPYABLE(Symbol);
AK_MAKE_NONMOVABLE(Symbol);
public:
Symbol(String, bool);