RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-26 05:37:35 +00:00
Code Issues Activity Actions

LibProtocol: Remove Request::stream_into(OutputStream&)

Browse source
This commit is contained in:
Tim Schumacher 2023-01-14 11:41:55 +01:00 • committed by Jelle Raaijmakers
parent 2313460b3e
commit 9f92e1bf11
2 changed files with 3 additions and 19 deletions
Download patch file Download diff file Expand all files Collapse all files

19
Userland/Libraries/LibProtocol/Request.cpp
View file

@ -20,8 +20,7 @@ bool Request::stop()
return m_client->stop_request({}, *this);
}
template<typename T>
void Request::stream_into_impl(T& stream)
void Request::stream_into(Core::Stream::Stream& stream)
{
VERIFY(!m_internal_stream_data);
@ -54,10 +53,8 @@ void Request::stream_into_impl(T& stream)
auto read_bytes = result.release_value();
if (read_bytes.is_empty())
break;
if (!stream.write_or_error(read_bytes)) {
// FIXME: What do we do here?
TODO();
}
// FIXME: What do we do if this fails?
stream.write_entire_buffer(read_bytes).release_value_but_fixme_should_propagate_errors();
break;
} while (true);
@ -69,16 +66,6 @@ void Request::stream_into_impl(T& stream)
};
}
void Request::stream_into(Core::Stream::Stream& stream)
{
stream_into_impl(stream);
}
void Request::stream_into(OutputStream& stream)
{
stream_into_impl(stream);
}
void Request::set_should_buffer_all_input(bool value)
{
if (m_should_buffer_all_input == value)