RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-05-28 22:15:07 +00:00
Code Issues Activity Actions

LibJS: Remove shift, pop, push functions from Array object

Browse source 
This abstraction isn't really that useful, as we can access the
underlying Vector<Value> using elements() and operate on it directly.
This commit is contained in:
Linus Groh 2020-04-13 16:21:54 +01:00 • committed by Andreas Kling
parent d74ad81402
commit 9fab52a390
6 changed files with 18 additions and 40 deletions
Download patch file Download diff file Expand all files Collapse all files

19
Libraries/LibJS/Runtime/Array.cpp
View file

@ -41,25 +41,6 @@ Array::~Array()
{
}
Value Array::shift()
{
if (elements().size() == 0)
return js_undefined();
return Value(elements().take_first());
}
Value Array::pop()
{
if (elements().size() == 0)
return js_undefined();
return Value(elements().take_last());
}
void Array::push(Value value)
{
elements().append(value);
}
Value Array::length_getter(Interpreter& interpreter)
{
auto* this_object = interpreter.this_value().to_object(interpreter.heap());