RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-24 19:47:42 +00:00
Code Issues Activity Actions

Meta: Remove unused "prefix" variable from invoke_generator() helper

Browse source 
This became unused after 1ae0cfd.
This commit is contained in:
Timothy Flynn 2022-10-16 11:53:48 -04:00 • committed by Linus Groh
parent 0cf3cb6279
commit 9fad23018a
6 changed files with 3 additions and 18 deletions
Download patch file Download diff file Expand all files Collapse all files

5
Meta/CMake/libweb_generators.cmake
View file

@ -4,7 +4,6 @@ function (generate_css_implementation)
"Enums.cpp" "Enums.cpp"
Lagom::GenerateCSSEnums Lagom::GenerateCSSEnums
"${LIBWEB_INPUT_FOLDER}/CSS/Enums.json" "${LIBWEB_INPUT_FOLDER}/CSS/Enums.json"
""
"CSS/Enums.h" "CSS/Enums.h"
"CSS/Enums.cpp" "CSS/Enums.cpp"
arguments -j "${LIBWEB_INPUT_FOLDER}/CSS/Enums.json" arguments -j "${LIBWEB_INPUT_FOLDER}/CSS/Enums.json"
@ -14,7 +13,6 @@ function (generate_css_implementation)
"MediaFeatureID.cpp" "MediaFeatureID.cpp"
Lagom::GenerateCSSMediaFeatureID Lagom::GenerateCSSMediaFeatureID
"${LIBWEB_INPUT_FOLDER}/CSS/MediaFeatures.json" "${LIBWEB_INPUT_FOLDER}/CSS/MediaFeatures.json"
""
"CSS/MediaFeatureID.h" "CSS/MediaFeatureID.h"
"CSS/MediaFeatureID.cpp" "CSS/MediaFeatureID.cpp"
arguments -j "${LIBWEB_INPUT_FOLDER}/CSS/MediaFeatures.json" arguments -j "${LIBWEB_INPUT_FOLDER}/CSS/MediaFeatures.json"
@ -24,7 +22,6 @@ function (generate_css_implementation)
"PropertyID.cpp" "PropertyID.cpp"
Lagom::GenerateCSSPropertyID Lagom::GenerateCSSPropertyID
"${LIBWEB_INPUT_FOLDER}/CSS/Properties.json" "${LIBWEB_INPUT_FOLDER}/CSS/Properties.json"
""
"CSS/PropertyID.h" "CSS/PropertyID.h"
"CSS/PropertyID.cpp" "CSS/PropertyID.cpp"
arguments -j "${LIBWEB_INPUT_FOLDER}/CSS/Properties.json" arguments -j "${LIBWEB_INPUT_FOLDER}/CSS/Properties.json"
@ -34,7 +31,6 @@ function (generate_css_implementation)
"TransformFunctions.cpp" "TransformFunctions.cpp"
Lagom::GenerateCSSTransformFunctions Lagom::GenerateCSSTransformFunctions
"${LIBWEB_INPUT_FOLDER}/CSS/TransformFunctions.json" "${LIBWEB_INPUT_FOLDER}/CSS/TransformFunctions.json"
""
"CSS/TransformFunctions.h" "CSS/TransformFunctions.h"
"CSS/TransformFunctions.cpp" "CSS/TransformFunctions.cpp"
arguments -j "${LIBWEB_INPUT_FOLDER}/CSS/TransformFunctions.json" arguments -j "${LIBWEB_INPUT_FOLDER}/CSS/TransformFunctions.json"
@ -44,7 +40,6 @@ function (generate_css_implementation)
"ValueID.cpp" "ValueID.cpp"
Lagom::GenerateCSSValueID Lagom::GenerateCSSValueID
"${LIBWEB_INPUT_FOLDER}/CSS/Identifiers.json" "${LIBWEB_INPUT_FOLDER}/CSS/Identifiers.json"
""
"CSS/ValueID.h" "CSS/ValueID.h"
"CSS/ValueID.cpp" "CSS/ValueID.cpp"
arguments -j "${LIBWEB_INPUT_FOLDER}/CSS/Identifiers.json" arguments -j "${LIBWEB_INPUT_FOLDER}/CSS/Identifiers.json"

5
Meta/CMake/locale_data.cmake
View file

@ -59,7 +59,6 @@ if (ENABLE_UNICODE_DATABASE_DOWNLOAD)
"DateTimeFormatData" "DateTimeFormatData"
Lagom::GenerateDateTimeFormatData Lagom::GenerateDateTimeFormatData
"${CLDR_VERSION_FILE}" "${CLDR_VERSION_FILE}"
""
"${DATE_TIME_FORMAT_DATA_HEADER}" "${DATE_TIME_FORMAT_DATA_HEADER}"
"${DATE_TIME_FORMAT_DATA_IMPLEMENTATION}" "${DATE_TIME_FORMAT_DATA_IMPLEMENTATION}"
arguments -r "${CLDR_CORE_PATH}" -d "${CLDR_DATES_PATH}" arguments -r "${CLDR_CORE_PATH}" -d "${CLDR_DATES_PATH}"
@ -68,7 +67,6 @@ if (ENABLE_UNICODE_DATABASE_DOWNLOAD)
"LocaleData" "LocaleData"
Lagom::GenerateLocaleData Lagom::GenerateLocaleData
"${CLDR_VERSION_FILE}" "${CLDR_VERSION_FILE}"
""
"${LOCALE_DATA_HEADER}" "${LOCALE_DATA_HEADER}"
"${LOCALE_DATA_IMPLEMENTATION}" "${LOCALE_DATA_IMPLEMENTATION}"
arguments -b "${CLDR_BCP47_PATH}" -r "${CLDR_CORE_PATH}" -l "${CLDR_LOCALES_PATH}" -m "${CLDR_MISC_PATH}" -n "${CLDR_NUMBERS_PATH}" -d "${CLDR_DATES_PATH}" arguments -b "${CLDR_BCP47_PATH}" -r "${CLDR_CORE_PATH}" -l "${CLDR_LOCALES_PATH}" -m "${CLDR_MISC_PATH}" -n "${CLDR_NUMBERS_PATH}" -d "${CLDR_DATES_PATH}"
@ -77,7 +75,6 @@ if (ENABLE_UNICODE_DATABASE_DOWNLOAD)
"NumberFormatData" "NumberFormatData"
Lagom::GenerateNumberFormatData Lagom::GenerateNumberFormatData
"${CLDR_VERSION_FILE}" "${CLDR_VERSION_FILE}"
""
"${NUMBER_FORMAT_DATA_HEADER}" "${NUMBER_FORMAT_DATA_HEADER}"
"${NUMBER_FORMAT_DATA_IMPLEMENTATION}" "${NUMBER_FORMAT_DATA_IMPLEMENTATION}"
arguments -r "${CLDR_CORE_PATH}" -n "${CLDR_NUMBERS_PATH}" -u "${CLDR_UNITS_PATH}" arguments -r "${CLDR_CORE_PATH}" -n "${CLDR_NUMBERS_PATH}" -u "${CLDR_UNITS_PATH}"
@ -86,7 +83,6 @@ if (ENABLE_UNICODE_DATABASE_DOWNLOAD)
"PluralRulesData" "PluralRulesData"
Lagom::GeneratePluralRulesData Lagom::GeneratePluralRulesData
"${CLDR_VERSION_FILE}" "${CLDR_VERSION_FILE}"
""
"${PLURAL_RULES_DATA_HEADER}" "${PLURAL_RULES_DATA_HEADER}"
"${PLURAL_RULES_DATA_IMPLEMENTATION}" "${PLURAL_RULES_DATA_IMPLEMENTATION}"
arguments -r "${CLDR_CORE_PATH}" -l "${CLDR_LOCALES_PATH}" arguments -r "${CLDR_CORE_PATH}" -l "${CLDR_LOCALES_PATH}"
@ -95,7 +91,6 @@ if (ENABLE_UNICODE_DATABASE_DOWNLOAD)
"RelativeTimeFormatData" "RelativeTimeFormatData"
Lagom::GenerateRelativeTimeFormatData Lagom::GenerateRelativeTimeFormatData
"${CLDR_VERSION_FILE}" "${CLDR_VERSION_FILE}"
""
"${RELATIVE_TIME_FORMAT_DATA_HEADER}" "${RELATIVE_TIME_FORMAT_DATA_HEADER}"
"${RELATIVE_TIME_FORMAT_DATA_IMPLEMENTATION}" "${RELATIVE_TIME_FORMAT_DATA_IMPLEMENTATION}"
arguments -d "${CLDR_DATES_PATH}" arguments -d "${CLDR_DATES_PATH}"

2
Meta/CMake/pnp_ids.cmake
View file

@ -8,13 +8,11 @@ if (ENABLE_PNP_IDS_DOWNLOAD)
set(PNP_IDS_HEADER PnpIDs.h) set(PNP_IDS_HEADER PnpIDs.h)
set(PNP_IDS_IMPLEMENTATION PnpIDs.cpp) set(PNP_IDS_IMPLEMENTATION PnpIDs.cpp)
set(PNP_IDS_TARGET_PREFIX "")
invoke_generator( invoke_generator(
"PnpIDsData" "PnpIDsData"
Lagom::GeneratePnpIDsData Lagom::GeneratePnpIDsData
"${PNP_IDS_EXPORT_PATH}" "${PNP_IDS_EXPORT_PATH}"
"${PNP_IDS_TARGET_PREFIX}"
"${PNP_IDS_HEADER}" "${PNP_IDS_HEADER}"
"${PNP_IDS_IMPLEMENTATION}" "${PNP_IDS_IMPLEMENTATION}"
arguments -p "${PNP_IDS_EXPORT_PATH}" arguments -p "${PNP_IDS_EXPORT_PATH}"

1
Meta/CMake/time_zone_data.cmake
View file

@ -72,7 +72,6 @@ if (ENABLE_TIME_ZONE_DATABASE_DOWNLOAD)
"TimeZoneData" "TimeZoneData"
Lagom::GenerateTimeZoneData Lagom::GenerateTimeZoneData
"${TZDB_VERSION_FILE}" "${TZDB_VERSION_FILE}"
""
"TimeZoneData.h" "TimeZoneData.h"
"TimeZoneData.cpp" "TimeZoneData.cpp"
arguments -z "${TZDB_ZONE_1970_PATH}" "${TZDB_AFRICA_PATH}" "${TZDB_ANTARCTICA_PATH}" "${TZDB_ASIA_PATH}" "${TZDB_AUSTRALASIA_PATH}" "${TZDB_BACKWARD_PATH}" "${TZDB_ETCETERA_PATH}" "${TZDB_EUROPE_PATH}" "${TZDB_NORTH_AMERICA_PATH}" "${TZDB_SOUTH_AMERICA_PATH}" arguments -z "${TZDB_ZONE_1970_PATH}" "${TZDB_AFRICA_PATH}" "${TZDB_ANTARCTICA_PATH}" "${TZDB_ASIA_PATH}" "${TZDB_AUSTRALASIA_PATH}" "${TZDB_BACKWARD_PATH}" "${TZDB_ETCETERA_PATH}" "${TZDB_EUROPE_PATH}" "${TZDB_NORTH_AMERICA_PATH}" "${TZDB_SOUTH_AMERICA_PATH}"

2
Meta/CMake/unicode_data.cmake
View file

@ -100,7 +100,6 @@ if (ENABLE_UNICODE_DATABASE_DOWNLOAD)
"UnicodeData" "UnicodeData"
Lagom::GenerateUnicodeData Lagom::GenerateUnicodeData
"${UCD_VERSION_FILE}" "${UCD_VERSION_FILE}"
""
"${UNICODE_DATA_HEADER}" "${UNICODE_DATA_HEADER}"
"${UNICODE_DATA_IMPLEMENTATION}" "${UNICODE_DATA_IMPLEMENTATION}"
arguments -u "${UNICODE_DATA_PATH}" -s "${SPECIAL_CASING_PATH}" -g "${DERIVED_GENERAL_CATEGORY_PATH}" -p "${PROP_LIST_PATH}" -d "${DERIVED_CORE_PROP_PATH}" -b "${DERIVED_BINARY_PROP_PATH}" -a "${PROP_ALIAS_PATH}" -v "${PROP_VALUE_ALIAS_PATH}" -r "${SCRIPTS_PATH}" -x "${SCRIPT_EXTENSIONS_PATH}" -k "${BLOCKS_PATH}" -e "${EMOJI_DATA_PATH}" -m "${NAME_ALIAS_PATH}" -n "${NORM_PROPS_PATH}" -f "${GRAPHEME_BREAK_PROP_PATH}" -w "${WORD_BREAK_PROP_PATH}" -i "${SENTENCE_BREAK_PROP_PATH}" arguments -u "${UNICODE_DATA_PATH}" -s "${SPECIAL_CASING_PATH}" -g "${DERIVED_GENERAL_CATEGORY_PATH}" -p "${PROP_LIST_PATH}" -d "${DERIVED_CORE_PROP_PATH}" -b "${DERIVED_BINARY_PROP_PATH}" -a "${PROP_ALIAS_PATH}" -v "${PROP_VALUE_ALIAS_PATH}" -r "${SCRIPTS_PATH}" -x "${SCRIPT_EXTENSIONS_PATH}" -k "${BLOCKS_PATH}" -e "${EMOJI_DATA_PATH}" -m "${NAME_ALIAS_PATH}" -n "${NORM_PROPS_PATH}" -f "${GRAPHEME_BREAK_PROP_PATH}" -w "${WORD_BREAK_PROP_PATH}" -i "${SENTENCE_BREAK_PROP_PATH}"
@ -109,7 +108,6 @@ if (ENABLE_UNICODE_DATABASE_DOWNLOAD)
"EmojiData" "EmojiData"
Lagom::GenerateEmojiData Lagom::GenerateEmojiData
"${UCD_VERSION_FILE}" "${UCD_VERSION_FILE}"
""
"${EMOJI_DATA_HEADER}" "${EMOJI_DATA_HEADER}"
"${EMOJI_DATA_IMPLEMENTATION}" "${EMOJI_DATA_IMPLEMENTATION}"
arguments -e "${EMOJI_TEST_PATH}" -s "${EMOJI_SERENITY_PATH}" arguments -e "${EMOJI_TEST_PATH}" -s "${EMOJI_SERENITY_PATH}"

6
Meta/CMake/utils.cmake
View file

@ -177,7 +177,7 @@ function(remove_path_if_version_changed version version_file cache_path)
endif() endif()
endfunction() endfunction()
function(invoke_generator name generator version_file prefix header implementation) function(invoke_generator name generator version_file header implementation)
cmake_parse_arguments(invoke_generator "" "" "arguments" ${ARGN}) cmake_parse_arguments(invoke_generator "" "" "arguments" ${ARGN})
add_custom_command( add_custom_command(
@ -190,8 +190,8 @@ function(invoke_generator name generator version_file prefix header implementati
DEPENDS ${generator} "${version_file}" DEPENDS ${generator} "${version_file}"
) )
add_custom_target("generate_${prefix}${name}" DEPENDS "${header}" "${implementation}") add_custom_target("generate_${name}" DEPENDS "${header}" "${implementation}")
add_dependencies(all_generated "generate_${prefix}${name}") add_dependencies(all_generated "generate_${name}")
endfunction() endfunction()
function(download_file url path) function(download_file url path)