RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-25 23:07:35 +00:00
Code Issues Activity Actions

Spreadsheet: Prevent infinite loop in Range ctor

Browse source
This commit is contained in:
u9g 2022-03-03 18:04:03 -05:00 • committed by Ali Mohammad Pur
parent 12ef20b869
commit 9fcd3f7920
1 changed files with 4 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

4
Base/res/js/Spreadsheet/runtime.js
View file

@ -187,6 +187,10 @@ class Range {
// using == to account for '0' since js will parse `+'0'` to 0
if (columnStep == 0 || rowStep == 0)
throw new Error("rowStep or columnStep is 0, this will cause an infinite loop");
if (typeof startingRow === "string" || typeof endingRow === "string")
throw new Error(
"startingRow or endingRow is a string, this will cause an infinite loop"
);
this.startingColumnName = startingColumnName;
this.endingColumnName = endingColumnName;
this.startingRow = startingRow;