RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-26 11:17:44 +00:00
Code Issues Activity Actions

WindowServer: Fix some gliches when overlays are moved or removed

Browse source 
Keep track of areas that overlays were rendered to when we recompute
occlusions. This allows us to then easily figure out areas where
overlays were moved from or removed from.
This commit is contained in:
Tom 2023-04-03 21:32:09 -06:00 • committed by Linus Groh
parent 426d1b7410
commit 9ff1fa1cf3
4 changed files with 35 additions and 19 deletions
Download patch file Download diff file Expand all files Collapse all files

11
Userland/Services/WindowServer/Overlays.cpp
View file

@ -13,7 +13,8 @@ namespace WindowServer {
Overlay::~Overlay()
{
Compositor::the().remove_overlay(*this);
if (is_enabled())
Compositor::the().remove_overlay(*this);
}
bool Overlay::invalidate()
@ -21,9 +22,8 @@ bool Overlay::invalidate()
if (m_invalidated)
return false;
m_invalidated = true;
// m_current_rect should only get updated by recompute_overlay_rects()
if (!m_current_rect.is_empty())
Compositor::the().invalidate_screen(m_current_rect);
if (is_enabled())
Compositor::the().overlay_rects_changed();
return true;
}
@ -45,8 +45,6 @@ void Overlay::set_rect(Gfx::IntRect const& rect)
auto previous_rect = m_rect;
m_rect = rect;
invalidate();
if (is_enabled())
Compositor::the().overlay_rects_changed();
rect_changed(previous_rect);
}
@ -257,6 +255,7 @@ void WindowGeometryOverlay::update_rect()
rect.set_bottom_without_resize(desktop_rect.bottom());
set_rect(rect);
invalidate_content(); // needed in case the rectangle itself doesn't change. But the contents did.
} else {
set_enabled(false);
}