From a0b2e8608bb9caea2e952db743b20013136e4172 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?kleines=20Filmr=C3=B6llchen?= Date: Sat, 23 Jul 2022 15:44:16 +0200 Subject: [PATCH] Piano: Remove waveform cycling with C This is not the most useful keyboard binding anyways, plus it will be extremely hacky to implement it with the generic processor parameter widgets. Therefore, we'll get rid of it and add back a more generic keyboard binding system later. --- Userland/Applications/Piano/KnobsWidget.cpp | 5 ----- Userland/Applications/Piano/KnobsWidget.h | 1 - Userland/Applications/Piano/MainWidget.cpp | 3 --- 3 files changed, 9 deletions(-) diff --git a/Userland/Applications/Piano/KnobsWidget.cpp b/Userland/Applications/Piano/KnobsWidget.cpp index 4c9c7538cb..59d332716e 100644 --- a/Userland/Applications/Piano/KnobsWidget.cpp +++ b/Userland/Applications/Piano/KnobsWidget.cpp @@ -104,11 +104,6 @@ KnobsWidget::KnobsWidget(TrackManager& track_manager, MainWidget& main_widget) } } -void KnobsWidget::cycle_waveform() -{ - m_synth_waveform->set_selected_index((m_synth_waveform->selected_index() + 1) % m_synth_waveform->model()->row_count()); -} - void KnobsWidget::update_knobs() { // FIXME: This is needed because when the slider is changed normally, we diff --git a/Userland/Applications/Piano/KnobsWidget.h b/Userland/Applications/Piano/KnobsWidget.h index af3d55a352..b8d9fefcb9 100644 --- a/Userland/Applications/Piano/KnobsWidget.h +++ b/Userland/Applications/Piano/KnobsWidget.h @@ -26,7 +26,6 @@ public: virtual ~KnobsWidget() override = default; void update_knobs(); - void cycle_waveform(); private: KnobsWidget(TrackManager&, MainWidget&); diff --git a/Userland/Applications/Piano/MainWidget.cpp b/Userland/Applications/Piano/MainWidget.cpp index b413a38298..e95ae70d01 100644 --- a/Userland/Applications/Piano/MainWidget.cpp +++ b/Userland/Applications/Piano/MainWidget.cpp @@ -115,9 +115,6 @@ void MainWidget::special_key_action(int key_code) case Key_X: set_octave_and_ensure_note_change(DSP::Keyboard::Direction::Up); break; - case Key_C: - m_knobs_widget->cycle_waveform(); - break; case Key_Space: m_player_widget->toggle_paused(); break;