RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-26 02:57:36 +00:00
Code Issues Activity Actions

Ladybird: Do not domain match on cookie updates

Browse source 
This matches a corresponding change to Serenity's Browser.
This commit is contained in:
Timothy Flynn 2022-12-05 10:15:41 -05:00 • committed by Andrew Kaster
parent 5b8d1a6f61
commit a0cd260410
3 changed files with 6 additions and 6 deletions
Download patch file Download diff file Expand all files Collapse all files

4
Ladybird/BrowserWindow.cpp
View file

@ -322,8 +322,8 @@ void BrowserWindow::new_tab()
m_cookie_jar.set_cookie(url, cookie, source); m_cookie_jar.set_cookie(url, cookie, source);
}; };
tab_ptr->view().on_update_cookie = [this](auto const& url, auto const& cookie) { tab_ptr->view().on_update_cookie = [this](auto const& cookie) {
m_cookie_jar.update_cookie(url, cookie); m_cookie_jar.update_cookie(cookie);
}; };
tab_ptr->focus_location_editor(); tab_ptr->focus_location_editor();

4
Ladybird/WebContentView.cpp
View file

@ -974,10 +974,10 @@ void WebContentView::notify_server_did_set_cookie(Badge<WebContentClient>, AK::U
on_set_cookie(url, cookie, source); on_set_cookie(url, cookie, source);
} }
void WebContentView::notify_server_did_update_cookie(Badge<WebContentClient>, AK::URL const& url, Web::Cookie::Cookie const& cookie) void WebContentView::notify_server_did_update_cookie(Badge<WebContentClient>, Web::Cookie::Cookie const& cookie)
{ {
if (on_update_cookie) if (on_update_cookie)
on_update_cookie(url, cookie); on_update_cookie(cookie);
} }
void WebContentView::notify_server_did_update_resource_count(i32 count_waiting) void WebContentView::notify_server_did_update_resource_count(i32 count_waiting)

4
Ladybird/WebContentView.h
View file

@ -75,7 +75,7 @@ public:
Function<Optional<Web::Cookie::Cookie>(AK::URL const& url, DeprecatedString const& name)> on_get_named_cookie; Function<Optional<Web::Cookie::Cookie>(AK::URL const& url, DeprecatedString const& name)> on_get_named_cookie;
Function<DeprecatedString(const AK::URL& url, Web::Cookie::Source source)> on_get_cookie; Function<DeprecatedString(const AK::URL& url, Web::Cookie::Source source)> on_get_cookie;
Function<void(const AK::URL& url, Web::Cookie::ParsedCookie const& cookie, Web::Cookie::Source source)> on_set_cookie; Function<void(const AK::URL& url, Web::Cookie::ParsedCookie const& cookie, Web::Cookie::Source source)> on_set_cookie;
Function<void(AK::URL const& url, Web::Cookie::Cookie const& cookie)> on_update_cookie; Function<void(Web::Cookie::Cookie const& cookie)> on_update_cookie;
Function<void(i32 count_waiting)> on_resource_status_change; Function<void(i32 count_waiting)> on_resource_status_change;
virtual void paintEvent(QPaintEvent*) override; virtual void paintEvent(QPaintEvent*) override;
@ -147,7 +147,7 @@ public:
virtual Optional<Web::Cookie::Cookie> notify_server_did_request_named_cookie(Badge<WebContentClient>, AK::URL const& url, DeprecatedString const& name) override; virtual Optional<Web::Cookie::Cookie> notify_server_did_request_named_cookie(Badge<WebContentClient>, AK::URL const& url, DeprecatedString const& name) override;
virtual DeprecatedString notify_server_did_request_cookie(Badge<WebContentClient>, const AK::URL& url, Web::Cookie::Source source) override; virtual DeprecatedString notify_server_did_request_cookie(Badge<WebContentClient>, const AK::URL& url, Web::Cookie::Source source) override;
virtual void notify_server_did_set_cookie(Badge<WebContentClient>, const AK::URL& url, Web::Cookie::ParsedCookie const& cookie, Web::Cookie::Source source) override; virtual void notify_server_did_set_cookie(Badge<WebContentClient>, const AK::URL& url, Web::Cookie::ParsedCookie const& cookie, Web::Cookie::Source source) override;
virtual void notify_server_did_update_cookie(Badge<WebContentClient>, AK::URL const& url, Web::Cookie::Cookie const& cookie) override; virtual void notify_server_did_update_cookie(Badge<WebContentClient>, Web::Cookie::Cookie const& cookie) override;
virtual void notify_server_did_update_resource_count(i32 count_waiting) override; virtual void notify_server_did_update_resource_count(i32 count_waiting) override;
virtual void notify_server_did_request_restore_window() override; virtual void notify_server_did_request_restore_window() override;
virtual Gfx::IntPoint notify_server_did_request_reposition_window(Gfx::IntPoint) override; virtual Gfx::IntPoint notify_server_did_request_reposition_window(Gfx::IntPoint) override;