diff --git a/Meta/Lagom/CMakeLists.txt b/Meta/Lagom/CMakeLists.txt index b91396e474..5425d89dc5 100644 --- a/Meta/Lagom/CMakeLists.txt +++ b/Meta/Lagom/CMakeLists.txt @@ -1,4 +1,4 @@ -cmake_minimum_required (VERSION 3.16) +cmake_minimum_required (VERSION 3.21) project( Lagom @@ -538,10 +538,10 @@ if (BUILD_LAGOM) add_executable(gzip ../../Userland/Utilities/gzip.cpp) target_link_libraries(gzip LibCompress LibCore LibMain) - # FIXME: Use PROJECT_IS_TOPLEVEL with cmake 3.21 - # Work around bug in JetBrains distributed CMake 3.27.2 where this causes infinite recursion in - # export_components() when called from CLion Nova by checking if we already have Ladybird included - if (ENABLE_LAGOM_LADYBIRD AND NOT ladybird_SOURCE_DIR) + # Work around bug in JetBrains distributed CMake 3.27.2 where this causes infinite recursion in + # export_components() when called from CLion Nova by checking if we already have Ladybird included + # This technically breaks people including Lagom as a submodule and wanting Ladybird targets, but... who? why? + if (ENABLE_LAGOM_LADYBIRD AND PROJECT_IS_TOP_LEVEL) add_serenity_subdirectory(Ladybird) endif()