RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-10-31 16:02:45 +00:00
Code Issues Activity Actions

Kernel: Ignore allocation failures during thread finalization

Browse source 
We ignore allocation failures above the first 32 guaranteed thread
slots, and just flag our future-selves to finalize these threads at a
later point.
This commit is contained in:
Idan Horowitz 2022-01-26 18:34:31 +02:00 • committed by Linus Groh
parent 7e9df6ddba
commit a0f404551e
2 changed files with 11 additions and 4 deletions
Download patch file Download diff file Expand all files Collapse all files

9
Kernel/Thread.cpp
View file

@ -529,8 +529,13 @@ void Thread::finalize_dying_threads()
{
SpinlockLocker lock(g_scheduler_lock);
for_each_in_state(Thread::State::Dying, [&](Thread& thread) {
if (thread.is_finalizable())
dying_threads.append(&thread);
if (!thread.is_finalizable())
return;
auto result = dying_threads.try_append(&thread);
// We ignore allocation failures above the first 32 guaranteed thread slots, and
// just flag our future-selves to finalize these threads at a later point
if (result.is_error())
g_finalizer_has_work.store(true, AK::MemoryOrder::memory_order_release);
});
}
for (auto* thread : dying_threads) {