RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-27 19:17:44 +00:00
Code Issues Activity Actions

WindowServer+MouseSettings: Add ability to configure double-click speed (#5876)

Browse source 
This adds a double-click speed slider control to the Mouse Settings
panel, and value labels for both the movement speed and double-click
speed sliders.

To allow for updating and persisting the configured double-click
speed through the WindowServer, two IPC calls - `SetDoubleClickSpeed`
and `GetDoubleClickSpeed` - have been added.
This commit is contained in:
Daniël van de Burgt 2021-04-02 07:08:18 -07:00 • committed by GitHub
parent e55b8712d4
commit a106f852d3
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
10 changed files with 315 additions and 70 deletions
Download patch file Download diff file Expand all files Collapse all files

13
Userland/Services/WindowServer/ClientConnection.cpp
View file

@ -966,6 +966,19 @@ OwnPtr<Messages::WindowServer::GetScrollStepSizeResponse> ClientConnection::hand
{
return make<Messages::WindowServer::GetScrollStepSizeResponse>(Screen::the().scroll_step_size());
}
OwnPtr<Messages::WindowServer::SetDoubleClickSpeedResponse> ClientConnection::handle(const Messages::WindowServer::SetDoubleClickSpeed& message)
{
if (message.speed() < double_click_speed_min || message.speed() > double_click_speed_max) {
did_misbehave("SetDoubleClickSpeed with bad speed");
return {};
}
WindowManager::the().set_double_click_speed(message.speed());
return make<Messages::WindowServer::SetDoubleClickSpeedResponse>();
}
OwnPtr<Messages::WindowServer::GetDoubleClickSpeedResponse> ClientConnection::handle(const Messages::WindowServer::GetDoubleClickSpeed&)
{
return make<Messages::WindowServer::GetDoubleClickSpeedResponse>(WindowManager::the().double_click_speed());
}
void ClientConnection::set_unresponsive(bool unresponsive)
{

2
Userland/Services/WindowServer/ClientConnection.h
View file

@ -169,6 +169,8 @@ private:
virtual OwnPtr<Messages::WindowServer::SetScrollStepSizeResponse> handle(const Messages::WindowServer::SetScrollStepSize&) override;
virtual OwnPtr<Messages::WindowServer::GetScrollStepSizeResponse> handle(const Messages::WindowServer::GetScrollStepSize&) override;
virtual OwnPtr<Messages::WindowServer::GetScreenBitmapResponse> handle(const Messages::WindowServer::GetScreenBitmap&) override;
virtual OwnPtr<Messages::WindowServer::SetDoubleClickSpeedResponse> handle(const Messages::WindowServer::SetDoubleClickSpeed&) override;
virtual OwnPtr<Messages::WindowServer::GetDoubleClickSpeedResponse> handle(const Messages::WindowServer::GetDoubleClickSpeed&) override;
Window* window_from_id(i32 window_id);

14
Userland/Services/WindowServer/WindowManager.cpp
View file

@ -171,6 +171,20 @@ void WindowManager::set_scroll_step_size(unsigned step_size)
m_config->sync();
}
void WindowManager::set_double_click_speed(int speed)
{
VERIFY(speed >= double_click_speed_min && speed <= double_click_speed_max);
m_double_click_speed = speed;
dbgln("Saving double-click speed {} to config file at {}", speed, m_config->file_name());
m_config->write_entry("Input", "DoubleClickSpeed", String::number(speed));
m_config->sync();
}
int WindowManager::double_click_speed() const
{
return m_double_click_speed;
}
int WindowManager::scale_factor() const
{
return Screen::the().scale_factor();

5
Userland/Services/WindowServer/WindowManager.h
View file

@ -47,6 +47,9 @@
namespace WindowServer {
const int double_click_speed_max = 900;
const int double_click_speed_min = 100;
class Screen;
class MouseEvent;
class Window;
@ -151,6 +154,8 @@ public:
void set_acceleration_factor(double);
void set_scroll_step_size(unsigned);
void set_double_click_speed(int);
int double_click_speed() const;
Window* set_active_input_window(Window*);
void restore_active_input_window(Window*);

3
Userland/Services/WindowServer/WindowServer.ipc
View file

@ -127,4 +127,7 @@ endpoint WindowServer = 2
GetScreenBitmap() => (Gfx::ShareableBitmap bitmap)
Pong() =|
SetDoubleClickSpeed(int speed) => ()
GetDoubleClickSpeed() => (int speed)
}