RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-06-01 12:08:14 +00:00
Code Issues Activity Actions

LibChess: Return ErrorOr<String> from to-algebraic/fen methods

Browse source 
Also, avoid creating temporary Strings for numbers, and stop appending
empty StringViews.
This commit is contained in:
Sam Atkins 2023-04-24 12:51:33 +01:00 • committed by Andreas Kling
parent 5f6dd87163
commit a10cc37ef0
4 changed files with 59 additions and 58 deletions
Download patch file Download diff file Expand all files Collapse all files

6
Userland/Libraries/LibChess/UCICommand.cpp
View file

@ -141,7 +141,7 @@ ErrorOr<String> PositionCommand::to_string() const
TRY(builder.try_append("moves"sv));
for (auto& move : moves()) {
TRY(builder.try_append(' '));
TRY(builder.try_append(move.to_long_algebraic()));
TRY(builder.try_append(TRY(move.to_long_algebraic())));
}
TRY(builder.try_append('\n'));
return builder.to_string();
@ -202,7 +202,7 @@ ErrorOr<String> GoCommand::to_string() const
TRY(builder.try_append(" searchmoves"sv));
for (auto& move : searchmoves.value()) {
TRY(builder.try_append(' '));
TRY(builder.try_append(move.to_long_algebraic()));
TRY(builder.try_append(TRY(move.to_long_algebraic())));
}
}
@ -318,7 +318,7 @@ ErrorOr<String> BestMoveCommand::to_string() const
{
StringBuilder builder;
TRY(builder.try_append("bestmove "sv));
TRY(builder.try_append(move().to_long_algebraic()));
TRY(builder.try_append(TRY(move().to_long_algebraic())));
TRY(builder.try_append('\n'));
return builder.to_string();
}