RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-25 16:57:35 +00:00
Code Issues Activity Actions

LibJS: Add Handle<T>, a strong C++ handle for keeping GC objects alive

Browse source 
This is pretty heavy and unoptimized, but it will do the trick for now.
Basically, Heap now has a HashTable<HandleImpl*> and you can call
JS::make_handle(T*) to construct a Handle<T> that guarantees that the
pointee will always survive GC until the Handle<T> is destroyed.
This commit is contained in:
Andreas Kling 2020-03-18 20:03:17 +01:00
parent e265058768
commit a119b61782
6 changed files with 103 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

6
Libraries/LibJS/Heap/Heap.h
View file

@ -26,11 +26,13 @@
#pragma once
#include <AK/HashTable.h>
#include <AK/Noncopyable.h>
#include <AK/NonnullOwnPtr.h>
#include <AK/Types.h>
#include <AK/Vector.h>
#include <LibJS/Forward.h>
#include <LibJS/Heap/Handle.h>
#include <LibJS/Runtime/Cell.h>
namespace JS {
@ -58,6 +60,9 @@ public:
bool should_collect_on_every_allocation() const { return m_should_collect_on_every_allocation; }
void set_should_collect_on_every_allocation(bool b) { m_should_collect_on_every_allocation = b; }
void did_create_handle(Badge<HandleImpl>, HandleImpl&);
void did_destroy_handle(Badge<HandleImpl>, HandleImpl&);
private:
Cell* allocate_cell(size_t);
@ -72,6 +77,7 @@ private:
Interpreter& m_interpreter;
Vector<NonnullOwnPtr<HeapBlock>> m_blocks;
HashTable<HandleImpl*> m_handles;
};
}