RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-26 06:57:46 +00:00
Code Issues Activity Actions

Build: Stop using precompiled headers (PCH)

Browse source 
This had very bad interactions with ccache, often leading to rebuilds
with 100% cache misses, etc. Ali says it wasn't that big of a speedup
in the end anyway, so let's not bother with it.

We can always bring it back in the future if it seems like a good idea.
This commit is contained in:
Andreas Kling 2021-05-17 18:48:37 +02:00
parent a5603c35df
commit a15c7b7944
6 changed files with 0 additions and 46 deletions
Download patch file Download diff file Expand all files Collapse all files

9
Meta/CMake/precompile-headers.cmake
View file

@ -1,9 +0,0 @@
function(serenity_add_precompiled_header_to_target target header)
if (PRECOMPILE_COMMON_HEADERS AND COMMAND target_precompile_headers)
target_precompile_headers(${target} PRIVATE ${header})
endif ()
endfunction()
function(serenity_add_ak_precompiled_headers_to_target target)
serenity_add_precompiled_header_to_target(${target} ${CMAKE_SOURCE_DIR}/Meta/Precompile/AK.h)
endfunction()

4
Meta/CMake/utils.cmake
View file

@ -1,5 +1,3 @@
include(${CMAKE_SOURCE_DIR}/Meta/CMake/precompile-headers.cmake)
function(serenity_install_headers target_name)
file(GLOB_RECURSE headers RELATIVE ${CMAKE_CURRENT_SOURCE_DIR} "*.h")
foreach(header ${headers})
@ -32,7 +30,6 @@ function(serenity_lib target_name fs_name)
add_library(${target_name} SHARED ${SOURCES} ${GENERATED_SOURCES})
install(TARGETS ${target_name} DESTINATION usr/lib)
set_target_properties(${target_name} PROPERTIES OUTPUT_NAME ${fs_name})
serenity_add_ak_precompiled_headers_to_target(${target_name})
serenity_generated_sources(${target_name})
endfunction()
@ -69,7 +66,6 @@ endfunction()
function(serenity_bin target_name)
add_executable(${target_name} ${SOURCES})
install(TARGETS ${target_name} RUNTIME DESTINATION bin)
serenity_add_ak_precompiled_headers_to_target(${target_name})
serenity_generated_sources(${target_name})
endfunction()