RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-26 09:57:34 +00:00
Code Issues Activity Actions

LibWeb: Paint separate borders for inline tables

Browse source
This commit is contained in:
Andi Gallo 2023-08-14 09:24:48 +00:00 • committed by Alexander Kalenik
parent c838bb3f21
commit a18500c78c
4 changed files with 37 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

3
Tests/LibWeb/Ref/manifest.json
View file

@ -1,3 +1,4 @@
{ {
"square-flex.html": "square-ref.html" "square-flex.html": "square-ref.html",
"separate-borders-inline-table.html": "separate-borders-ref.html"
} }

17
Tests/LibWeb/Ref/separate-borders-inline-table.html Normal file
View file

@ -0,0 +1,17 @@
<style type="text/css">
td {
border: 5px solid blue;
padding: 20px;
}
table {
border: 5px solid black;
display: inline-block;
border-collapse: separate;
}
</style>
<table>
<tr>
<td>A</td>
</tr>
</table>

16
Tests/LibWeb/Ref/separate-borders-ref.html Normal file
View file

@ -0,0 +1,16 @@
<style type="text/css">
td {
border: 5px solid blue;
padding: 20px;
}
table {
border: 5px solid black;
border-collapse: separate;
}
</style>
<table>
<tr>
<td>A</td>
</tr>
</table>

2
Userland/Libraries/LibWeb/Painting/StackingContext.cpp
View file

@ -136,6 +136,8 @@ void StackingContext::paint_descendants(PaintContext& context, Layout::Node cons
if (child_is_inline_or_replaced) { if (child_is_inline_or_replaced) {
paint_node(child, context, PaintPhase::Background); paint_node(child, context, PaintPhase::Background);
paint_node(child, context, PaintPhase::Border); paint_node(child, context, PaintPhase::Border);
if (child.display().is_table_inside() && child.computed_values().border_collapse() == CSS::BorderCollapse::Separate)
paint_table_borders(context, child);
paint_descendants(context, child, StackingContextPaintPhase::BackgroundAndBorders); paint_descendants(context, child, StackingContextPaintPhase::BackgroundAndBorders);
} }
paint_descendants(context, child, phase); paint_descendants(context, child, phase);