RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-27 00:07:36 +00:00
Code Issues Activity Actions

VFS: unlink() should fail when called on a directory.

Browse source
This commit is contained in:
Andreas Kling 2019-01-23 05:35:42 +01:00
parent 754037874c
commit a1b4f719ba
1 changed files with 6 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

6
Kernel/VirtualFileSystem.cpp
View file

@ -245,6 +245,12 @@ bool VFS::unlink(const String& path, Inode& base, int& error)
return false; return false;
} }
auto inode = get_inode(inode_id);
if (inode->is_directory()) {
error = -EISDIR;
return false;
}
auto parent_inode = get_inode(parent_dir); auto parent_inode = get_inode(parent_dir);
// FIXME: The reverse_lookup here can definitely be avoided. // FIXME: The reverse_lookup here can definitely be avoided.
if (!parent_inode->remove_child(parent_inode->reverse_lookup(inode_id), error)) if (!parent_inode->remove_child(parent_inode->reverse_lookup(inode_id), error))