RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-26 04:27:44 +00:00
Code Issues Activity Actions

LibGUI+Settings: Remove superfluous margin sets

Browse source 
The margin set is completely superfluous, because it only ever affects
grabbing (in splitters), which is never used for these classes.
This commit is contained in:
FrHun 2021-09-14 20:45:32 +02:00 • committed by Andreas Kling
parent a08685b9a4
commit a261e4d9d5
3 changed files with 0 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

1
Userland/Applications/KeyboardSettings/main.cpp
View file

@ -149,7 +149,6 @@ int main(int argc, char** argv)
bottom_widget.set_layout<GUI::HorizontalBoxLayout>(); bottom_widget.set_layout<GUI::HorizontalBoxLayout>();
bottom_widget.layout()->add_spacer(); bottom_widget.layout()->add_spacer();
bottom_widget.set_fixed_height(30); bottom_widget.set_fixed_height(30);
bottom_widget.set_content_margins({ 4, 0 });
auto& ok_button = bottom_widget.add<GUI::Button>(); auto& ok_button = bottom_widget.add<GUI::Button>();
ok_button.set_text("OK"); ok_button.set_text("OK");

1
Userland/Libraries/LibGUI/AboutDialog.cpp
View file

@ -62,7 +62,6 @@ AboutDialog::AboutDialog(const StringView& name, const Gfx::Bitmap* icon, Window
auto& label = right_container.add<Label>(text); auto& label = right_container.add<Label>(text);
label.set_text_alignment(Gfx::TextAlignment::CenterLeft); label.set_text_alignment(Gfx::TextAlignment::CenterLeft);
label.set_fixed_height(14); label.set_fixed_height(14);
label.set_content_margins({ 0, 8, 0 });
if (bold) if (bold)
label.set_font(Gfx::FontDatabase::default_font().bold_variant()); label.set_font(Gfx::FontDatabase::default_font().bold_variant());
}; };

1
Userland/Libraries/LibGUI/ProcessChooser.cpp
View file

@ -48,7 +48,6 @@ ProcessChooser::ProcessChooser(const StringView& window_title, const StringView&
auto& button_container = widget.add<GUI::Widget>(); auto& button_container = widget.add<GUI::Widget>();
button_container.set_fixed_height(30); button_container.set_fixed_height(30);
button_container.set_layout<GUI::HorizontalBoxLayout>(); button_container.set_layout<GUI::HorizontalBoxLayout>();
button_container.set_content_margins({ 4, 0 });
button_container.layout()->set_margins({ 0, 4, 0 }); button_container.layout()->set_margins({ 0, 4, 0 });
button_container.layout()->add_spacer(); button_container.layout()->add_spacer();