RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-26 08:27:45 +00:00
Code Issues Activity Actions

LibJS: Use OrderedHashMap instead of HashMap in the Map built-in

Browse source 
This ensures insertion-order iteration.
This commit is contained in:
Idan Horowitz 2021-06-16 00:00:26 +03:00 • committed by Linus Groh
parent f1f00be691
commit a27fbfd45f
2 changed files with 4 additions and 4 deletions
Download patch file Download diff file Expand all files Collapse all files

6
Userland/Libraries/LibJS/Runtime/Map.h
View file

@ -22,13 +22,13 @@ public:
explicit Map(Object& prototype); explicit Map(Object& prototype);
virtual ~Map() override; virtual ~Map() override;
HashMap<Value, Value, ValueTraits> const& entries() const { return m_entries; }; OrderedHashMap<Value, Value, ValueTraits> const& entries() const { return m_entries; };
HashMap<Value, Value, ValueTraits>& entries() { return m_entries; }; OrderedHashMap<Value, Value, ValueTraits>& entries() { return m_entries; };
private: private:
virtual void visit_edges(Visitor& visitor) override; virtual void visit_edges(Visitor& visitor) override;
HashMap<Value, Value, ValueTraits> m_entries; // FIXME: Replace with a HashMap that maintains a linked list of insertion order for correct iteration order OrderedHashMap<Value, Value, ValueTraits> m_entries;
}; };
} }

2
Userland/Libraries/LibJS/Runtime/MapIterator.h
View file

@ -33,7 +33,7 @@ private:
Map& m_map; Map& m_map;
bool m_done { false }; bool m_done { false };
Object::PropertyKind m_iteration_kind; Object::PropertyKind m_iteration_kind;
HashMap<Value, Value, ValueTraits>::IteratorType m_iterator; OrderedHashMap<Value, Value, ValueTraits>::IteratorType m_iterator;
}; };
} }