RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-05-31 00:48:11 +00:00
Code Issues Activity Actions

LibJS: Simplify MemberExpression::generate_bytecode()

Browse source 
Use the get-from-reference helper in BytecodeGenerator.
This commit is contained in:
Andreas Kling 2021-10-25 16:04:31 +02:00
parent 72cd31d033
commit a2a8b97c11
1 changed files with 1 additions and 12 deletions
Download patch file Download diff file Expand all files Collapse all files

13
Userland/Libraries/LibJS/Bytecode/ASTCodegen.cpp
View file

@ -572,18 +572,7 @@ void ArrayExpression::generate_bytecode(Bytecode::Generator& generator) const
void MemberExpression::generate_bytecode(Bytecode::Generator& generator) const void MemberExpression::generate_bytecode(Bytecode::Generator& generator) const
{ {
object().generate_bytecode(generator); generator.emit_load_from_reference(*this);
if (is_computed()) {
auto object_reg = generator.allocate_register();
generator.emit<Bytecode::Op::Store>(object_reg);
property().generate_bytecode(generator);
generator.emit<Bytecode::Op::GetByValue>(object_reg);
} else {
auto identifier_table_ref = generator.intern_identifier(verify_cast<Identifier>(property()).string());
generator.emit<Bytecode::Op::GetById>(identifier_table_ref);
}
} }
void FunctionDeclaration::generate_bytecode(Bytecode::Generator&) const void FunctionDeclaration::generate_bytecode(Bytecode::Generator&) const