From a2b57dd188add8d5ff03bc778ecf1d5536b90166 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Julian=20Offenh=C3=A4user?= Date: Sat, 11 Feb 2023 20:58:14 +0100 Subject: [PATCH] LibPDF: Return an error if we fail to load a replacement font --- Userland/Libraries/LibPDF/Fonts/PDFFont.cpp | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/Userland/Libraries/LibPDF/Fonts/PDFFont.cpp b/Userland/Libraries/LibPDF/Fonts/PDFFont.cpp index 5fdf3a4b63..ed38f7d650 100644 --- a/Userland/Libraries/LibPDF/Fonts/PDFFont.cpp +++ b/Userland/Libraries/LibPDF/Fonts/PDFFont.cpp @@ -38,7 +38,8 @@ PDFErrorOr PDFFont::CommonData::load_from_dict(Document* document, Nonnull auto replacement = replacement_for_standard_latin_font(base_font); float point_size = (font_size * POINTS_PER_INCH) / DEFAULT_DPI; font = Gfx::FontDatabase::the().get(replacement.get<0>(), replacement.get<1>(), point_size); - VERIFY(font); + if (!font) + return Error(Error::Type::Internal, DeprecatedString::formatted("Failed to load {} {} at {}pt", replacement.get<0>(), replacement.get<1>(), point_size)); } if (dict->contains(CommonNames::Encoding)) {