RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-25 13:17:35 +00:00
Code Issues Activity Actions

LibJS: Throw a RangeError when when formatting strings in DurationFormat

Browse source 
This is a normative change in the Intl.DurationFormat proposal. See:
2546080
This commit is contained in:
Timothy Flynn 2022-12-14 15:30:34 -05:00 • committed by Linus Groh
parent 010888acec
commit a2cf026b30
3 changed files with 19 additions and 4 deletions
Download patch file Download diff file Expand all files Collapse all files

11
Userland/Libraries/LibJS/Runtime/Intl/DurationFormat.cpp
View file

@ -134,9 +134,16 @@ StringView DurationFormat::display_to_string(Display display)
// 1.1.3 ToDurationRecord ( input ), https://tc39.es/proposal-intl-duration-format/#sec-todurationrecord // 1.1.3 ToDurationRecord ( input ), https://tc39.es/proposal-intl-duration-format/#sec-todurationrecord
ThrowCompletionOr<Temporal::DurationRecord> to_duration_record(VM& vm, Value input) ThrowCompletionOr<Temporal::DurationRecord> to_duration_record(VM& vm, Value input)
{ {
// 1. If Type(input) is not Object, throw a TypeError exception. // 1. If Type(input) is not Object, then
if (!input.is_object()) if (!input.is_object()) {
// a. If Type(input) is String, throw a RangeError exception.
if (input.is_string())
return vm.throw_completion<RangeError>(ErrorType::NotAnObject, input);
// b. Throw a TypeError exception.
return vm.throw_completion<TypeError>(ErrorType::NotAnObject, input); return vm.throw_completion<TypeError>(ErrorType::NotAnObject, input);
}
auto& input_object = input.as_object(); auto& input_object = input.as_object();
// 2. Let result be a new Duration Record with each field set to 0. // 2. Let result be a new Duration Record with each field set to 0.

6
Userland/Libraries/LibJS/Tests/builtins/Intl/DurationFormat/DurationFormat.prototype.format.js
View file

@ -92,7 +92,11 @@ describe("correct behavior", () => {
describe("errors", () => { describe("errors", () => {
test("non-object duration records", () => { test("non-object duration records", () => {
[-100, Infinity, NaN, "hello", 152n, Symbol("foo")].forEach(value => { expect(() => {
new Intl.DurationFormat().format("hello");
}).toThrowWithMessage(RangeError, "is not an object");
[-100, Infinity, NaN, 152n, Symbol("foo"), true, null, undefined].forEach(value => {
expect(() => { expect(() => {
new Intl.DurationFormat().format(value); new Intl.DurationFormat().format(value);
}).toThrowWithMessage(TypeError, "is not an object"); }).toThrowWithMessage(TypeError, "is not an object");

6
Userland/Libraries/LibJS/Tests/builtins/Intl/DurationFormat/DurationFormat.prototype.formatToParts.js
View file

@ -266,7 +266,11 @@ describe("correct behavior", () => {
describe("errors", () => { describe("errors", () => {
test("non-object duration records", () => { test("non-object duration records", () => {
[-100, Infinity, NaN, "hello", 152n, Symbol("foo")].forEach(value => { expect(() => {
new Intl.DurationFormat().formatToParts("hello");
}).toThrowWithMessage(RangeError, "is not an object");
[-100, Infinity, NaN, 152n, Symbol("foo"), true, null, undefined].forEach(value => {
expect(() => { expect(() => {
new Intl.DurationFormat().formatToParts(value); new Intl.DurationFormat().formatToParts(value);
}).toThrowWithMessage(TypeError, "is not an object"); }).toThrowWithMessage(TypeError, "is not an object");