RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-27 04:57:45 +00:00
Code Issues Activity Actions

LibSanitizer: Abort on unrecoverable UBSan errors

Browse source 
There is no sensible recovery possible from non-void functions that
fail to return a value, or from `__builtin_unreachable()` being reached,
all bets are off once they happened. This is why LLVM's libsanitizer
treats these as always fatal, even if all other UBSan checks are made
recoverable with `-fsanitize-recover`. The codegen already assumes that
these handlers will not return.
This commit is contained in:
Daniel Bertalan 2023-08-12 10:50:15 +02:00 • committed by Andreas Kling
parent 1653c5ea41
commit a2d352c4c9
1 changed files with 16 additions and 12 deletions
Download patch file Download diff file Expand all files Collapse all files

28
Userland/Libraries/LibSanitizer/UBSanitizer.cpp
View file

@ -15,6 +15,12 @@ Atomic<bool> AK::UBSanitizer::g_ubsan_is_deadly;
warnln(fmt, ##__VA_ARGS__); \ warnln(fmt, ##__VA_ARGS__); \
dbgln("\x1B[31m" fmt "\x1B[0m", ##__VA_ARGS__); dbgln("\x1B[31m" fmt "\x1B[0m", ##__VA_ARGS__);
#define ABORT_ALWAYS() \
do { \
WARNLN_AND_DBGLN("UBSAN: This error is not recoverable"); \
abort(); \
} while (0)
extern "C" { extern "C" {
static void print_location(SourceLocation const& location) static void print_location(SourceLocation const& location)
@ -47,6 +53,10 @@ static void print_location(SourceLocation const& location)
} }
} }
// Calls to these functions are automatically inserted by the compiler,
// so there is no point in declaring them in a header.
#pragma GCC diagnostic ignored "-Wmissing-declarations"
void __ubsan_handle_load_invalid_value(InvalidValueData&, ValueHandle) __attribute__((used)); void __ubsan_handle_load_invalid_value(InvalidValueData&, ValueHandle) __attribute__((used));
void __ubsan_handle_load_invalid_value(InvalidValueData& data, ValueHandle) void __ubsan_handle_load_invalid_value(InvalidValueData& data, ValueHandle)
{ {
@ -233,24 +243,18 @@ void __ubsan_handle_alignment_assumption(AlignmentAssumptionData& data, ValueHan
print_location(location); print_location(location);
} }
void __ubsan_handle_builtin_unreachable(UnreachableData&) __attribute__((used)); [[gnu::used, noreturn]] void __ubsan_handle_builtin_unreachable(UnreachableData& data)
void __ubsan_handle_builtin_unreachable(UnreachableData& data)
{ {
auto location = data.location.permanently_clear();
if (!location.needs_logging())
return;
WARNLN_AND_DBGLN("UBSAN: execution reached an unreachable program point"); WARNLN_AND_DBGLN("UBSAN: execution reached an unreachable program point");
print_location(location); print_location(data.location);
ABORT_ALWAYS();
} }
void __ubsan_handle_missing_return(UnreachableData&) __attribute__((used)); [[gnu::used, noreturn]] void __ubsan_handle_missing_return(UnreachableData& data)
void __ubsan_handle_missing_return(UnreachableData& data)
{ {
auto location = data.location.permanently_clear();
if (!location.needs_logging())
return;
WARNLN_AND_DBGLN("UBSAN: execution reached the end of a value-returning function without returning a value"); WARNLN_AND_DBGLN("UBSAN: execution reached the end of a value-returning function without returning a value");
print_location(location); print_location(data.location);
ABORT_ALWAYS();
} }
void __ubsan_handle_implicit_conversion(ImplicitConversionData&, ValueHandle, ValueHandle) __attribute__((used)); void __ubsan_handle_implicit_conversion(ImplicitConversionData&, ValueHandle, ValueHandle) __attribute__((used));