RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-25 05:27:43 +00:00
Code Issues Activity Actions

LibJS: Parse slashes after reserved identifiers correctly

Browse source 
Previously we were unable to parse code like `yield/2` because `/2`
was parsed as a regex. At the same time `for (a in / b/)` was parsed
as a division.

This is solved by defaulting to division in the lexer, but calling
`force_slash_as_regex()` from the parser whenever an IdentifierName
is parsed as a ReservedWord.
This commit is contained in:
Simon Wanner 2023-05-28 00:08:52 +02:00 • committed by Andreas Kling
parent b0bd1e5eb5
commit a2efecac03
6 changed files with 65 additions and 25 deletions
Download patch file Download diff file Expand all files Collapse all files

6
Userland/Libraries/LibJS/Tests/modules/basic-modules.js
View file

@ -210,6 +210,12 @@ describe("in- and exports", () => {
test("can have top level using declarations which trigger at the end of running a module", () => {
expectModulePassed("./top-level-dispose.mjs");
});
test("can export default a RegExp", () => {
const result = expectModulePassed("./default-regexp-export.mjs");
expect(result.default).toBeInstanceOf(RegExp);
expect(result.default.toString()).toBe(/foo/.toString());
});
});
describe("loops", () => {