From a30b341a2ca6cb13d88886dfe7c19a7fabd598b8 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Andreas=20Oppeb=C3=B8en?= Date: Wed, 1 Mar 2023 21:19:45 +0100 Subject: [PATCH] LibGUI: Fix value slider so dragging left and right feels similar When dragging value slider left, the handle would snap to lower value with the slightest move of the mouse. When dragging to the right however, it would take a lot more movement to cause a change in value. This asymmetry made it feel awkward to drag the mouse around. It was caused by always rounding down using a cast to int. By rounding to the nearest integer first, we ensure symmetric behavior. --- Userland/Libraries/LibGUI/ValueSlider.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Userland/Libraries/LibGUI/ValueSlider.cpp b/Userland/Libraries/LibGUI/ValueSlider.cpp index e7e7de95e2..3d868913dd 100644 --- a/Userland/Libraries/LibGUI/ValueSlider.cpp +++ b/Userland/Libraries/LibGUI/ValueSlider.cpp @@ -146,7 +146,7 @@ int ValueSlider::value_at(Gfx::IntPoint position) const float relative_offset = (float)(position.x() - bar_rect().left()) / (float)bar_rect().width(); int range = max() - min(); - return min() + (int)(relative_offset * (float)range); + return min() + (int)roundf(relative_offset * (float)range); } void ValueSlider::set_value(int value, AllowCallback allow_callback, DoClamp do_clamp)