RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-05-31 14:48:14 +00:00
Code Issues Activity Actions

LibJS/JIT: Expand Mul fast path to double & i32 combinations

Browse source 
Co-authored-by: Stephan Vedder <vedder@mbits.info>
This commit is contained in:
Simon Wanner 2023-11-10 09:06:43 +01:00 • committed by Andreas Kling
parent 867b8146cf
commit a3399fa13a
2 changed files with 35 additions and 30 deletions
Download patch file Download diff file Expand all files Collapse all files

53
Userland/Libraries/LibJS/JIT/Compiler.cpp
View file

@ -695,36 +695,29 @@ void Compiler::compile_mul(Bytecode::Op::Mul const& op)
load_vm_register(ARG1, op.lhs());
load_accumulator(ARG2);
Assembler::Label end {};
Assembler::Label slow_case {};
branch_if_both_int32(ARG1, ARG2, [&] {
// GPR0 = ARG1 * ARG2 (32-bit)
// if (overflow) goto slow_case;
m_assembler.mov(
Assembler::Operand::Register(GPR0),
Assembler::Operand::Register(ARG1));
m_assembler.mul32(
Assembler::Operand::Register(GPR0),
Assembler::Operand::Register(ARG2),
slow_case);
// accumulator = GPR0 | SHIFTED_INT32_TAG;
m_assembler.mov(
Assembler::Operand::Register(GPR1),
Assembler::Operand::Imm(SHIFTED_INT32_TAG));
m_assembler.bitwise_or(
Assembler::Operand::Register(GPR0),
Assembler::Operand::Register(GPR1));
store_accumulator(GPR0);
m_assembler.jump(end);
});
slow_case.link(m_assembler);
native_call((void*)cxx_mul);
store_accumulator(RET);
check_exception();
end.link(m_assembler);
branch_if_both_numbers(
ARG1, ARG2,
[&](auto lhs, auto rhs, auto& slow_case) {
m_assembler.mul32(
Assembler::Operand::Register(lhs),
Assembler::Operand::Register(rhs),
slow_case);
return lhs; },
[&](auto lhs, auto rhs) {
m_assembler.mul(
Assembler::Operand::FloatRegister(lhs),
Assembler::Operand::FloatRegister(rhs));
return lhs; },
[&](auto lhs, auto rhs) {
m_assembler.mov(
Assembler::Operand::Register(ARG1),
Assembler::Operand::Register(lhs));
m_assembler.mov(
Assembler::Operand::Register(ARG2),
Assembler::Operand::Register(rhs));
native_call((void*)cxx_mul);
return RET;
});
}
# define DO_COMPILE_COMPARISON_OP(TitleCaseName, snake_case_name, AssemblerCondition) \