RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-05-31 23:58:11 +00:00
Code Issues Activity Actions

LibGfx/TIFF: Consider ASCII and UTF-8 as containers

Browse source 
The generator will now create APIs that return a single `String`
instead of a `Vector<String>`.
This commit is contained in:
Lucas CHOLLET 2023-12-02 17:59:43 -05:00 • committed by Andreas Kling
parent a8caa3edbc
commit a382ea7c1f
1 changed files with 3 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

4
Userland/Libraries/LibGfx/TIFFGenerator.py
View file

@ -104,6 +104,8 @@ def tiff_type_to_cpp(t: TIFFType, without_promotion: bool = False) -> str:
# Note that the Value<> type doesn't include u16 for this reason
if not without_promotion:
t = promote_type(t)
if t in [TIFFType.ASCII, TIFFType.UTF8]:
return 'String'
if t == TIFFType.Undefined:
return 'ByteBuffer'
if t == TIFFType.UnsignedShort:
@ -119,7 +121,7 @@ def is_container(t: TIFFType) -> bool:
An example of that are ASCII strings defined as N * byte. Let's intercept that and generate
a nice API instead of Vector<u8>.
"""
return t in [TIFFType.Byte, TIFFType.Undefined]
return t in [TIFFType.ASCII, TIFFType.Byte, TIFFType.Undefined, TIFFType.UTF8]
def export_promoter() -> str: