RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-05-31 14:38:11 +00:00
Code Issues Activity Actions

Kernel+LibC: Implement seteuid() and friends!

Browse source 
Add seteuid()/setegid() under _POSIX_SAVED_IDS semantics,
which also requires adding suid and sgid to Process, and
changing setuid()/setgid() to honor these semantics.

The exact semantics aren't specified by POSIX and differ
between different Unix implementations. This patch makes
serenity follow FreeBSD. The 2002 USENIX paper
"Setuid Demystified" explains the differences well.

In addition to seteuid() and setegid() this also adds
setreuid()/setregid() and setresuid()/setresgid(), and
the accessors getresuid()/getresgid().

Also reorder uid/euid functions so that they are the
same order everywhere (namely, the order that
geteuid()/getuid() already have).
This commit is contained in:
Nico Weber 2020-06-17 08:58:00 -04:00 • committed by Andreas Kling
parent 0001bbf182
commit a38754d9f2
5 changed files with 251 additions and 26 deletions
Download patch file Download diff file Expand all files Collapse all files

66
Libraries/LibC/unistd.cpp
View file

@ -177,16 +177,6 @@ int execlp(const char* filename, const char* arg0, ...)
return execvpe(filename, const_cast<char* const*>(args.data()), environ);
}
uid_t getuid()
{
return syscall(SC_getuid);
}
gid_t getgid()
{
return syscall(SC_getgid);
}
uid_t geteuid()
{
return syscall(SC_geteuid);
@ -197,6 +187,16 @@ gid_t getegid()
return syscall(SC_getegid);
}
uid_t getuid()
{
return syscall(SC_getuid);
}
gid_t getgid()
{
return syscall(SC_getgid);
}
pid_t getpid()
{
return syscall(SC_getpid);
@ -207,6 +207,16 @@ pid_t getppid()
return syscall(SC_getppid);
}
int getresuid(uid_t* ruid, uid_t* euid, uid_t* suid)
{
return syscall(SC_getresuid, ruid, euid, suid);
}
int getresgid(gid_t *rgid, gid_t *egid, gid_t *sgid)
{
return syscall(SC_getresgid, rgid, egid, sgid);
}
pid_t getsid(pid_t pid)
{
int rc = syscall(SC_getsid, pid);
@ -457,6 +467,18 @@ unsigned int alarm(unsigned int seconds)
return syscall(SC_alarm, seconds);
}
int seteuid(uid_t euid)
{
int rc = syscall(SC_seteuid, euid);
__RETURN_WITH_ERRNO(rc, rc, -1);
}
int setegid(gid_t egid)
{
int rc = syscall(SC_setegid, egid);
__RETURN_WITH_ERRNO(rc, rc, -1);
}
int setuid(uid_t uid)
{
int rc = syscall(SC_setuid, uid);
@ -469,6 +491,30 @@ int setgid(gid_t gid)
__RETURN_WITH_ERRNO(rc, rc, -1);
}
int setreuid(uid_t ruid, uid_t euid)
{
int rc = syscall(SC_setreuid, ruid, euid);
__RETURN_WITH_ERRNO(rc, rc, -1);
}
int setregid(gid_t rgid, gid_t egid)
{
int rc = syscall(SC_setregid, rgid, egid);
__RETURN_WITH_ERRNO(rc, rc, -1);
}
int setresuid(uid_t ruid, uid_t euid, uid_t suid)
{
int rc = syscall(SC_setresuid, ruid, euid, suid);
__RETURN_WITH_ERRNO(rc, rc, -1);
}
int setresgid(gid_t rgid, gid_t egid, gid_t sgid)
{
int rc = syscall(SC_setresgid, rgid, egid, sgid);
__RETURN_WITH_ERRNO(rc, rc, -1);
}
int access(const char* pathname, int mode)
{
if (!pathname) {