RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-26 19:37:36 +00:00
Code Issues Activity Actions

SystemServer: Change user only when needed

Browse source
This commit is contained in:
Lucas CHOLLET 2022-07-24 13:22:40 +02:00 • committed by Linus Groh
parent a13ffffbec
commit a3b8a9a142
1 changed files with 1 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

2
Userland/Services/SystemServer/Service.cpp
View file

@ -211,7 +211,7 @@ void Service::spawn(int socket_fd)
setenv("SOCKET_TAKEOVER", builder.to_string().characters(), true); setenv("SOCKET_TAKEOVER", builder.to_string().characters(), true);
} }
if (m_account.has_value()) { if (m_account.has_value() && m_account.value().uid() != getuid()) {
auto& account = m_account.value(); auto& account = m_account.value();
if (setgid(account.gid()) < 0 || setgroups(account.extra_gids().size(), account.extra_gids().data()) < 0 || setuid(account.uid()) < 0) { if (setgid(account.gid()) < 0 || setgroups(account.extra_gids().size(), account.extra_gids().data()) < 0 || setuid(account.uid()) < 0) {
dbgln("Failed to drop privileges (GID={}, UID={})\n", account.gid(), account.uid()); dbgln("Failed to drop privileges (GID={}, UID={})\n", account.gid(), account.uid());