Browser+WebContent+WebDriver: Move Get Named Cookie to WebContent

Instead of sending *all* cookies over IPC and filtering by name, we now
filter by name from the cookie jar and send just the first matching
cookie.

Userland/Services/WebContent/WebDriverClient.ipc

@@ -25,6 +25,7 @@ endpoint WebDriverClient {
     execute_script(JsonValue payload) => (Web::WebDriver::Response response)
     execute_async_script(JsonValue payload) => (Web::WebDriver::Response response)
     get_all_cookies() => (Web::WebDriver::Response response)
+    get_named_cookie(String name) => (Web::WebDriver::Response response)
     take_screenshot() => (Web::WebDriver::Response response)
     take_element_screenshot(String element_id) => (Web::WebDriver::Response response)
 }

Userland/Services/WebContent/WebDriverConnection.cpp

@@ -872,6 +872,26 @@ Messages::WebDriverClient::GetAllCookiesResponse WebDriverConnection::get_all_co
     return make_success_response(move(cookies));
 }
 
+// 14.2 Get Named Cookie, https://w3c.github.io/webdriver/#dfn-get-named-cookie
+Messages::WebDriverClient::GetNamedCookieResponse WebDriverConnection::get_named_cookie(String const& name)
+{
+    // 1. If the current browsing context is no longer open, return error with error code no such window.
+    TRY(ensure_open_top_level_browsing_context());
+
+    // FIXME: 2. Handle any user prompts, and return its value if it is an error.
+
+    // 3. If the url variable name is equal to a cookie’s cookie name amongst all associated cookies of the current browsing context’s active document, return success with the serialized cookie as data.
+    auto* document = m_page_host.page().top_level_browsing_context().active_document();
+
+    if (auto cookie = m_web_content_client.did_request_named_cookie(document->url(), name); cookie.has_value()) {
+        auto serialized_cookie = serialize_cookie(*cookie);
+        return make_success_response(move(serialized_cookie));
+    }
+
+    // 4. Otherwise, return error with error code no such cookie.
+    return Web::WebDriver::Error::from_code(Web::WebDriver::ErrorCode::NoSuchCookie, String::formatted("Cookie '{}' not found", name));
+}
+
 // 17.1 Take Screenshot, https://w3c.github.io/webdriver/#take-screenshot
 Messages::WebDriverClient::TakeScreenshotResponse WebDriverConnection::take_screenshot()
 {

Userland/Services/WebContent/WebDriverConnection.h

@@ -57,6 +57,7 @@ private:
     virtual Messages::WebDriverClient::ExecuteScriptResponse execute_script(JsonValue const& payload) override;
     virtual Messages::WebDriverClient::ExecuteAsyncScriptResponse execute_async_script(JsonValue const& payload) override;
     virtual Messages::WebDriverClient::GetAllCookiesResponse get_all_cookies() override;
+    virtual Messages::WebDriverClient::GetNamedCookieResponse get_named_cookie(String const& name) override;
     virtual Messages::WebDriverClient::TakeScreenshotResponse take_screenshot() override;
     virtual Messages::WebDriverClient::TakeElementScreenshotResponse take_element_screenshot(String const& element_id) override;
 

Userland/Services/WebDriver/Client.cpp

@@ -762,8 +762,7 @@ Web::WebDriver::Response Client::handle_get_named_cookie(Vector<StringView> cons
 {
     dbgln_if(WEBDRIVER_DEBUG, "Handling GET /session/<session_id>/cookie/<name>");
     auto* session = TRY(find_session_with_id(parameters[0]));
-    auto cookies = TRY(session->get_named_cookie(parameters[1]));
-    return make_json_value(cookies);
+    return session->web_content_connection().get_named_cookie(parameters[1]);
 }
 
 // 14.3 Add Cookie, https://w3c.github.io/webdriver/#dfn-adding-a-cookie

Userland/Services/WebDriver/Session.cpp

@@ -297,43 +297,6 @@ Web::WebDriver::Response Session::get_window_handles() const
     return JsonValue { handles };
 }
 
-// https://w3c.github.io/webdriver/#dfn-serialized-cookie
-static JsonObject serialize_cookie(Web::Cookie::Cookie const& cookie)
-{
-    JsonObject serialized_cookie = {};
-    serialized_cookie.set("name", cookie.name);
-    serialized_cookie.set("value", cookie.value);
-    serialized_cookie.set("path", cookie.path);
-    serialized_cookie.set("domain", cookie.domain);
-    serialized_cookie.set("secure", cookie.secure);
-    serialized_cookie.set("httpOnly", cookie.http_only);
-    serialized_cookie.set("expiry", cookie.expiry_time.timestamp());
-    // FIXME: Add sameSite to Cookie and serialize it here too.
-
-    return serialized_cookie;
-}
-
-// 14.2 Get Named Cookie, https://w3c.github.io/webdriver/#dfn-get-named-cookie
-Web::WebDriver::Response Session::get_named_cookie(String const& name)
-{
-    // 1. If the current browsing context is no longer open, return error with error code no such window.
-    TRY(check_for_open_top_level_browsing_context_or_return_error());
-
-    // FIXME: 2. Handle any user prompts, and return its value if it is an error.
-
-    // 3. If the url variable name is equal to a cookie’s cookie name amongst all associated cookies of the
-    //    current browsing context’s active document, return success with the serialized cookie as data.
-    auto maybe_cookie = m_browser_connection->get_named_cookie(name);
-    if (maybe_cookie.has_value()) {
-        auto cookie = maybe_cookie.release_value();
-        auto serialized_cookie = serialize_cookie(cookie);
-        return JsonValue(serialized_cookie);
-    }
-
-    // 4. Otherwise, return error with error code no such cookie.
-    return Web::WebDriver::Error::from_code(Web::WebDriver::ErrorCode::NoSuchCookie, "Cookie not found");
-}
-
 // 14.3 Add Cookie, https://w3c.github.io/webdriver/#dfn-adding-a-cookie
 Web::WebDriver::Response Session::add_cookie(JsonValue const& payload)
 {

Userland/Services/WebDriver/Session.h

@@ -58,7 +58,6 @@ public:
     Web::WebDriver::Response get_window_handle();
     ErrorOr<void, Variant<Web::WebDriver::Error, Error>> close_window();
     Web::WebDriver::Response get_window_handles() const;
-    Web::WebDriver::Response get_named_cookie(String const& name);
     Web::WebDriver::Response add_cookie(JsonValue const& payload);
     Web::WebDriver::Response delete_cookie(StringView name);
     Web::WebDriver::Response delete_all_cookies();