RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-27 02:17:35 +00:00
Code Issues Activity Actions

Userland: Port GUI::Application::show_tooltip() to String

Browse source 
This most importantly gets rid of a chain of "String to DeprecatedString
to String" transformations when setting a tooltip from GUI::Widget's
set_tooltip function.
This commit is contained in:
Karol Kosek 2023-09-10 16:44:32 +02:00 • committed by Andreas Kling
parent 16defb4806
commit a3ddba4191
7 changed files with 12 additions and 12 deletions
Download patch file Download diff file Expand all files Collapse all files

2
Userland/Applications/Maps/MapWidget.cpp
View file

@ -187,7 +187,7 @@ void MapWidget::mousemove_event(GUI::MouseEvent& event)
marker_image->height()
};
if (marker_rect.contains(event.x(), event.y())) {
GUI::Application::the()->show_tooltip(marker.tooltip.value().to_deprecated_string(), this);
GUI::Application::the()->show_tooltip(marker.tooltip.value(), this);
return;
}
}

4
Userland/Applications/PixelPaint/Tools/GuideTool.cpp
View file

@ -74,7 +74,7 @@ void GuideTool::on_mousedown(Layer*, MouseEvent& event)
if (m_selected_guide) {
m_guide_origin = m_selected_guide->offset();
GUI::Application::the()->show_tooltip_immediately(DeprecatedString::formatted("{}", m_guide_origin), GUI::Application::the()->tooltip_source_widget());
GUI::Application::the()->show_tooltip_immediately(MUST(String::number(m_guide_origin)), GUI::Application::the()->tooltip_source_widget());
}
}
@ -120,7 +120,7 @@ void GuideTool::on_mousemove(Layer*, MouseEvent& event)
m_selected_guide->set_offset(new_offset);
GUI::Application::the()->show_tooltip_immediately(DeprecatedString::formatted("{}", new_offset), GUI::Application::the()->tooltip_source_widget());
GUI::Application::the()->show_tooltip_immediately(MUST(String::number(new_offset)), GUI::Application::the()->tooltip_source_widget());
editor()->update();
}