RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-25 22:27:35 +00:00
Code Issues Activity Actions

Userland: Remove erroneous String -> char* -> StringView conversions

Browse source 
These were accidental (or leftover) uses of String::characters() to
construct StringViews through its StringView(char const*) constructor.
Since this constructor is due to be removed, this will no longer work.
Plus this prevents strlen from being run on these strings unnecessarily.
This commit is contained in:
sin-ack 2022-07-11 20:44:47 +00:00 • committed by Andreas Kling
parent 60f6bc902b
commit a3eeeaa6a1
3 changed files with 3 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

2
Userland/DevTools/UserspaceEmulator/Emulator.cpp
View file

@ -113,7 +113,7 @@ void Emulator::setup_stack(Vector<ELF::AuxiliaryValue> aux_vector)
Vector<u32> env_entries;
for (auto const& variable : m_environment) {
m_cpu->push_string(variable.characters());
m_cpu->push_string(variable.view());
env_entries.append(m_cpu->esp().value());
}