1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-25 14:27:35 +00:00

Use fooEvent() type names for the virtual event handlers.

This commit is contained in:
Andreas Kling 2018-10-13 22:51:50 +02:00
parent dfb70ed234
commit a3fb19fe9c
20 changed files with 84 additions and 84 deletions

View file

@ -19,7 +19,7 @@ void Button::setCaption(String&& caption)
update(); update();
} }
void Button::onPaint(PaintEvent&) void Button::paintEvent(PaintEvent&)
{ {
Color buttonColor = Color::LightGray; Color buttonColor = Color::LightGray;
Color highlightColor = Color::White; Color highlightColor = Color::White;
@ -69,23 +69,23 @@ void Button::onPaint(PaintEvent&)
} }
} }
void Button::onMouseDown(MouseEvent& event) void Button::mouseDownEvent(MouseEvent& event)
{ {
printf("Button::onMouseDown: x=%d, y=%d, button=%u\n", event.x(), event.y(), (unsigned)event.button()); printf("Button::mouseDownEvent: x=%d, y=%d, button=%u\n", event.x(), event.y(), (unsigned)event.button());
m_beingPressed = true; m_beingPressed = true;
update(); update();
Widget::onMouseDown(event); Widget::mouseDownEvent(event);
} }
void Button::onMouseUp(MouseEvent& event) void Button::mouseUpEvent(MouseEvent& event)
{ {
printf("Button::onMouseUp: x=%d, y=%d, button=%u\n", event.x(), event.y(), (unsigned)event.button()); printf("Button::mouseUpEvent: x=%d, y=%d, button=%u\n", event.x(), event.y(), (unsigned)event.button());
m_beingPressed = false; m_beingPressed = false;
update(); update();
Widget::onMouseUp(event); Widget::mouseUpEvent(event);
} }

View file

@ -12,9 +12,9 @@ public:
void setCaption(String&&); void setCaption(String&&);
private: private:
virtual void onPaint(PaintEvent&) override; virtual void paintEvent(PaintEvent&) override;
virtual void onMouseDown(MouseEvent&) override; virtual void mouseDownEvent(MouseEvent&) override;
virtual void onMouseUp(MouseEvent&) override; virtual void mouseUpEvent(MouseEvent&) override;
virtual const char* className() const override { return "Button"; } virtual const char* className() const override { return "Button"; }

View file

@ -74,7 +74,7 @@ static const char* checkedBitmap = {
"###########" "###########"
}; };
void CheckBox::onPaint(PaintEvent&) void CheckBox::paintEvent(PaintEvent&)
{ {
Painter painter(*this); Painter painter(*this);
auto bitmap = CBitmap::createFromASCII(isChecked() ? checkedBitmap : uncheckedBitmap, 11, 11); auto bitmap = CBitmap::createFromASCII(isChecked() ? checkedBitmap : uncheckedBitmap, 11, 11);
@ -95,9 +95,9 @@ void CheckBox::onPaint(PaintEvent&)
} }
} }
void CheckBox::onMouseDown(MouseEvent& event) void CheckBox::mouseDownEvent(MouseEvent& event)
{ {
printf("CheckBox::onMouseDown: x=%d, y=%d, button=%u\n", event.x(), event.y(), (unsigned)event.button()); printf("CheckBox::mouseDownEvent: x=%d, y=%d, button=%u\n", event.x(), event.y(), (unsigned)event.button());
setIsChecked(!isChecked()); setIsChecked(!isChecked());
} }

View file

@ -15,8 +15,8 @@ public:
void setIsChecked(bool); void setIsChecked(bool);
private: private:
virtual void onPaint(PaintEvent&) override; virtual void paintEvent(PaintEvent&) override;
virtual void onMouseDown(MouseEvent&) override; virtual void mouseDownEvent(MouseEvent&) override;
virtual const char* className() const override { return "CheckBox"; } virtual const char* className() const override { return "CheckBox"; }

View file

@ -13,7 +13,7 @@ ClockWidget::~ClockWidget()
{ {
} }
void ClockWidget::onPaint(PaintEvent&) void ClockWidget::paintEvent(PaintEvent&)
{ {
auto now = time(nullptr); auto now = time(nullptr);
auto& tm = *localtime(&now); auto& tm = *localtime(&now);
@ -26,7 +26,7 @@ void ClockWidget::onPaint(PaintEvent&)
painter.drawText(rect(), timeBuf, Painter::TextAlignment::Center, Color::Black); painter.drawText(rect(), timeBuf, Painter::TextAlignment::Center, Color::Black);
} }
void ClockWidget::onTimer(TimerEvent&) void ClockWidget::timerEvent(TimerEvent&)
{ {
auto now = time(nullptr); auto now = time(nullptr);
if (now == m_lastSeenTimestamp) if (now == m_lastSeenTimestamp)

View file

@ -8,8 +8,8 @@ public:
virtual ~ClockWidget() override; virtual ~ClockWidget() override;
private: private:
virtual void onPaint(PaintEvent&) override; virtual void paintEvent(PaintEvent&) override;
virtual void onTimer(TimerEvent&) override; virtual void timerEvent(TimerEvent&) override;
dword m_lastSeenTimestamp { 0 }; dword m_lastSeenTimestamp { 0 };
}; };

View file

@ -19,7 +19,7 @@ void Label::setText(String&& text)
update(); update();
} }
void Label::onPaint(PaintEvent&) void Label::paintEvent(PaintEvent&)
{ {
Painter painter(*this); Painter painter(*this);
painter.fillRect({ 0, 0, width(), height() }, backgroundColor()); painter.fillRect({ 0, 0, width(), height() }, backgroundColor());
@ -27,9 +27,9 @@ void Label::onPaint(PaintEvent&)
painter.drawText({ 4, 4, width(), height() }, text(), Painter::TextAlignment::TopLeft, foregroundColor()); painter.drawText({ 4, 4, width(), height() }, text(), Painter::TextAlignment::TopLeft, foregroundColor());
} }
void Label::onMouseMove(MouseEvent& event) void Label::mouseMoveEvent(MouseEvent& event)
{ {
printf("Label::onMouseMove: x=%d, y=%d\n", event.x(), event.y()); printf("Label::mouseMoveEvent: x=%d, y=%d\n", event.x(), event.y());
Widget::onMouseMove(event); Widget::mouseMoveEvent(event);
} }

View file

@ -12,8 +12,8 @@ public:
void setText(String&&); void setText(String&&);
private: private:
virtual void onPaint(PaintEvent&) override; virtual void paintEvent(PaintEvent&) override;
virtual void onMouseMove(MouseEvent&) override; virtual void mouseMoveEvent(MouseEvent&) override;
virtual const char* className() const override { return "Label"; } virtual const char* className() const override { return "Label"; }

View file

@ -17,7 +17,7 @@ unsigned ListBox::itemHeight() const
return Font::defaultFont().glyphHeight() + 2; return Font::defaultFont().glyphHeight() + 2;
} }
void ListBox::onPaint(PaintEvent&) void ListBox::paintEvent(PaintEvent&)
{ {
Painter painter(*this); Painter painter(*this);
@ -44,9 +44,9 @@ void ListBox::onPaint(PaintEvent&)
} }
} }
void ListBox::onMouseDown(MouseEvent& event) void ListBox::mouseDownEvent(MouseEvent& event)
{ {
printf("ListBox::onMouseDown %d,%d\n", event.x(), event.y()); printf("ListBox::mouseDownEvent %d,%d\n", event.x(), event.y());
for (unsigned i = m_scrollOffset; i < m_items.size(); ++i) { for (unsigned i = m_scrollOffset; i < m_items.size(); ++i) {
Rect itemRect(1, 1 + (i * itemHeight()), width() - 2, itemHeight()); Rect itemRect(1, 1 + (i * itemHeight()), width() - 2, itemHeight());
if (itemRect.contains(event.position())) { if (itemRect.contains(event.position())) {

View file

@ -11,8 +11,8 @@ public:
int selectedIndex() const { return m_selectedIndex; } int selectedIndex() const { return m_selectedIndex; }
private: private:
virtual void onPaint(PaintEvent&) override; virtual void paintEvent(PaintEvent&) override;
virtual void onMouseDown(MouseEvent&) override; virtual void mouseDownEvent(MouseEvent&) override;
unsigned itemHeight() const; unsigned itemHeight() const;

View file

@ -27,7 +27,7 @@ void Object::event(Event& event)
{ {
switch (event.type()) { switch (event.type()) {
case Event::Timer: case Event::Timer:
return onTimer(static_cast<TimerEvent&>(event)); return timerEvent(static_cast<TimerEvent&>(event));
case Event::Invalid: case Event::Invalid:
ASSERT_NOT_REACHED(); ASSERT_NOT_REACHED();
break; break;
@ -51,7 +51,7 @@ void Object::removeChild(Object& object)
} }
} }
void Object::onTimer(TimerEvent&) void Object::timerEvent(TimerEvent&)
{ {
} }

View file

@ -25,7 +25,7 @@ public:
bool hasTimer() const { return m_timerID; } bool hasTimer() const { return m_timerID; }
private: private:
virtual void onTimer(TimerEvent&); virtual void timerEvent(TimerEvent&);
void addChild(Object&); void addChild(Object&);
void removeChild(Object&); void removeChild(Object&);

View file

@ -11,11 +11,11 @@ RootWidget::~RootWidget()
{ {
} }
void RootWidget::onPaint(PaintEvent& event) void RootWidget::paintEvent(PaintEvent& event)
{ {
Widget::onPaint(event); Widget::paintEvent(event);
printf("RootWidget::onPaint: %d,%d %dx%d\n", printf("RootWidget::paintEvent: %d,%d %dx%d\n",
event.rect().x(), event.rect().x(),
event.rect().y(), event.rect().y(),
event.rect().width(), event.rect().width(),
@ -24,9 +24,9 @@ void RootWidget::onPaint(PaintEvent& event)
painter.fillRect(event.rect(), Color(0, 72, 96)); painter.fillRect(event.rect(), Color(0, 72, 96));
} }
void RootWidget::onMouseMove(MouseEvent& event) void RootWidget::mouseMoveEvent(MouseEvent& event)
{ {
//printf("RootWidget::onMouseMove: x=%d, y=%d\n", event.x(), event.y()); //printf("RootWidget::mouseMoveEvent: x=%d, y=%d\n", event.x(), event.y());
Widget::onMouseMove(event); Widget::mouseMoveEvent(event);
} }

View file

@ -8,6 +8,6 @@ public:
virtual ~RootWidget() override; virtual ~RootWidget() override;
private: private:
virtual void onPaint(PaintEvent&) override; virtual void paintEvent(PaintEvent&) override;
virtual void onMouseMove(MouseEvent&) override; virtual void mouseMoveEvent(MouseEvent&) override;
}; };

View file

@ -60,7 +60,7 @@ CharacterWithAttributes& TerminalWidget::at(unsigned row, unsigned column)
return m_screen[row * columns() + column]; return m_screen[row * columns() + column];
} }
void TerminalWidget::onPaint(PaintEvent&) void TerminalWidget::paintEvent(PaintEvent&)
{ {
Painter painter(*this); Painter painter(*this);
painter.fillRect(rect(), Color::Black); painter.fillRect(rect(), Color::Black);
@ -144,16 +144,16 @@ void TerminalWidget::onReceive(byte ch)
update(); update();
} }
void TerminalWidget::onKeyDown(KeyEvent& event) void TerminalWidget::keyDownEvent(KeyEvent& event)
{ {
if (event.text().isEmpty()) if (event.text().isEmpty())
return; return;
write(g_fd, event.text().characters(), event.text().length()); write(g_fd, event.text().characters(), event.text().length());
} }
void TerminalWidget::onKeyUp(KeyEvent& event) void TerminalWidget::keyUpEvent(KeyEvent& event)
{ {
return Widget::onKeyUp(event); return Widget::keyUpEvent(event);
} }
void TerminalWidget::bell() void TerminalWidget::bell()
@ -165,7 +165,7 @@ void TerminalWidget::bell()
update(); update();
} }
void TerminalWidget::onTimer(TimerEvent&) void TerminalWidget::timerEvent(TimerEvent&)
{ {
m_belling = false; m_belling = false;
stopTimer(); stopTimer();

View file

@ -22,10 +22,10 @@ public:
private: private:
CharacterWithAttributes& at(unsigned row, unsigned column); CharacterWithAttributes& at(unsigned row, unsigned column);
virtual void onPaint(PaintEvent&) override; virtual void paintEvent(PaintEvent&) override;
virtual void onKeyDown(KeyEvent&) override; virtual void keyDownEvent(KeyEvent&) override;
virtual void onKeyUp(KeyEvent&) override; virtual void keyUpEvent(KeyEvent&) override;
virtual void onTimer(TimerEvent&) override; virtual void timerEvent(TimerEvent&) override;
void bell(); void bell();

View file

@ -21,7 +21,7 @@ void TextBox::setText(String&& text)
update(); update();
} }
void TextBox::onPaint(PaintEvent&) void TextBox::paintEvent(PaintEvent&)
{ {
Painter painter(*this); Painter painter(*this);
@ -63,7 +63,7 @@ void TextBox::onPaint(PaintEvent&)
} }
} }
void TextBox::onMouseDown(MouseEvent&) void TextBox::mouseDownEvent(MouseEvent&)
{ {
} }
@ -90,7 +90,7 @@ void TextBox::handleBackspace()
update(); update();
} }
void TextBox::onKeyDown(KeyEvent& event) void TextBox::keyDownEvent(KeyEvent& event)
{ {
switch (event.key()) { switch (event.key()) {
case KeyboardKey::LeftArrow: case KeyboardKey::LeftArrow:
@ -126,7 +126,7 @@ void TextBox::onKeyDown(KeyEvent& event)
} }
} }
void TextBox::onTimer(TimerEvent&) void TextBox::timerEvent(TimerEvent&)
{ {
// FIXME: Disable the timer when not focused. // FIXME: Disable the timer when not focused.
if (!isFocused()) if (!isFocused())

View file

@ -11,10 +11,10 @@ public:
void setText(String&&); void setText(String&&);
private: private:
virtual void onPaint(PaintEvent&) override; virtual void paintEvent(PaintEvent&) override;
virtual void onMouseDown(MouseEvent&) override; virtual void mouseDownEvent(MouseEvent&) override;
virtual void onKeyDown(KeyEvent&) override; virtual void keyDownEvent(KeyEvent&) override;
virtual void onTimer(TimerEvent&) override; virtual void timerEvent(TimerEvent&) override;
void handleBackspace(); void handleBackspace();

View file

@ -37,64 +37,64 @@ void Widget::event(Event& event)
return; return;
} }
m_hasPendingPaintEvent = false; m_hasPendingPaintEvent = false;
return onPaint(static_cast<PaintEvent&>(event)); return paintEvent(static_cast<PaintEvent&>(event));
case Event::Show: case Event::Show:
return onShow(static_cast<ShowEvent&>(event)); return showEvent(static_cast<ShowEvent&>(event));
case Event::Hide: case Event::Hide:
return onHide(static_cast<HideEvent&>(event)); return hideEvent(static_cast<HideEvent&>(event));
case Event::KeyDown: case Event::KeyDown:
return onKeyDown(static_cast<KeyEvent&>(event)); return keyDownEvent(static_cast<KeyEvent&>(event));
case Event::KeyUp: case Event::KeyUp:
return onKeyUp(static_cast<KeyEvent&>(event)); return keyUpEvent(static_cast<KeyEvent&>(event));
case Event::MouseMove: case Event::MouseMove:
return onMouseMove(static_cast<MouseEvent&>(event)); return mouseMoveEvent(static_cast<MouseEvent&>(event));
case Event::MouseDown: case Event::MouseDown:
if (auto* win = window()) { if (auto* win = window()) {
// FIXME: if (acceptsFocus()) // FIXME: if (acceptsFocus())
win->setFocusedWidget(this); win->setFocusedWidget(this);
} }
return onMouseDown(static_cast<MouseEvent&>(event)); return mouseDownEvent(static_cast<MouseEvent&>(event));
case Event::MouseUp: case Event::MouseUp:
return onMouseUp(static_cast<MouseEvent&>(event)); return mouseUpEvent(static_cast<MouseEvent&>(event));
default: default:
return Object::event(event); return Object::event(event);
} }
} }
void Widget::onPaint(PaintEvent& event) void Widget::paintEvent(PaintEvent& event)
{ {
//printf("Widget::onPaint :)\n"); //printf("Widget::paintEvent :)\n");
for (auto* ch : children()) { for (auto* ch : children()) {
auto* child = (Widget*)ch; auto* child = (Widget*)ch;
child->onPaint(event); child->paintEvent(event);
} }
} }
void Widget::onShow(ShowEvent&) void Widget::showEvent(ShowEvent&)
{ {
} }
void Widget::onHide(HideEvent&) void Widget::hideEvent(HideEvent&)
{ {
} }
void Widget::onKeyDown(KeyEvent&) void Widget::keyDownEvent(KeyEvent&)
{ {
} }
void Widget::onKeyUp(KeyEvent&) void Widget::keyUpEvent(KeyEvent&)
{ {
} }
void Widget::onMouseDown(MouseEvent&) void Widget::mouseDownEvent(MouseEvent&)
{ {
} }
void Widget::onMouseUp(MouseEvent&) void Widget::mouseUpEvent(MouseEvent&)
{ {
} }
void Widget::onMouseMove(MouseEvent&) void Widget::mouseMoveEvent(MouseEvent&)
{ {
} }

View file

@ -14,14 +14,14 @@ public:
virtual ~Widget(); virtual ~Widget();
virtual void event(Event&); virtual void event(Event&);
virtual void onPaint(PaintEvent&); virtual void paintEvent(PaintEvent&);
virtual void onShow(ShowEvent&); virtual void showEvent(ShowEvent&);
virtual void onHide(HideEvent&); virtual void hideEvent(HideEvent&);
virtual void onKeyDown(KeyEvent&); virtual void keyDownEvent(KeyEvent&);
virtual void onKeyUp(KeyEvent&); virtual void keyUpEvent(KeyEvent&);
virtual void onMouseMove(MouseEvent&); virtual void mouseMoveEvent(MouseEvent&);
virtual void onMouseDown(MouseEvent&); virtual void mouseDownEvent(MouseEvent&);
virtual void onMouseUp(MouseEvent&); virtual void mouseUpEvent(MouseEvent&);
Rect relativeRect() const { return m_relativeRect; } Rect relativeRect() const { return m_relativeRect; }
Point relativePosition() const { return m_relativeRect.location(); } Point relativePosition() const { return m_relativeRect.location(); }