RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-10-31 12:12:45 +00:00
Code Issues Activity Actions

LibWeb: Parse "width" and "height" presentation attributes on <img>

Browse source 
These are HTML lengths that map to CSS width and height respectively.
This commit is contained in:
Andreas Kling 2020-07-22 01:16:27 +02:00
parent 5a7e57457e
commit a3feb46ad7
2 changed files with 18 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

16
Libraries/LibWeb/DOM/HTMLImageElement.cpp
View file

@ -33,6 +33,7 @@
#include <LibWeb/DOM/HTMLImageElement.h>
#include <LibWeb/Layout/LayoutImage.h>
#include <LibWeb/Loader/ResourceLoader.h>
#include <LibWeb/Parser/CSSParser.h>
namespace Web {
@ -60,6 +61,21 @@ HTMLImageElement::~HTMLImageElement()
{
}
void HTMLImageElement::apply_presentational_hints(StyleProperties& style) const
{
for_each_attribute([&](auto& name, auto& value) {
if (name == HTML::AttributeNames::width) {
if (auto parsed_value = parse_html_length(document(), value)) {
style.set_property(CSS::PropertyID::Width, parsed_value.release_nonnull());
}
} else if (name == HTML::AttributeNames::height) {
if (auto parsed_value = parse_html_length(document(), value)) {
style.set_property(CSS::PropertyID::Height, parsed_value.release_nonnull());
}
}
});
}
void HTMLImageElement::parse_attribute(const FlyString& name, const String& value)
{
HTMLElement::parse_attribute(name, value);

2
Libraries/LibWeb/DOM/HTMLImageElement.h
View file

@ -51,6 +51,8 @@ public:
const Gfx::Bitmap* bitmap() const;
private:
virtual void apply_presentational_hints(StyleProperties&) const override;
void animate();
virtual RefPtr<LayoutNode> create_layout_node(const StyleProperties* parent_style) override;