RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-27 05:37:34 +00:00
Code Issues Activity Actions

Tests: Test set uid/gid not dropped upon file rename

Browse source
This commit is contained in:
Brendan Coles 2021-01-14 05:51:16 +00:00 • committed by Andreas Kling
parent b8c3ea8b30
commit a44739473b
1 changed files with 38 additions and 12 deletions
Download patch file Download diff file Expand all files Collapse all files

50
Userland/Tests/Kernel/filesystem-strips-file-suid-sgid-bits-when-modified.cpp
View file

@ -24,6 +24,8 @@
* OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
*/ */
#include <AK/String.h>
#include <LibCore/File.h>
#include <assert.h> #include <assert.h>
#include <fcntl.h> #include <fcntl.h>
#include <stdio.h> #include <stdio.h>
@ -48,11 +50,10 @@ static void test_change_file_contents()
struct stat s; struct stat s;
assert(fstat(fd, &s) != -1); assert(fstat(fd, &s) != -1);
close(fd); close(fd);
assert(s.st_mode & ~S_ISUID);
assert(s.st_mode & ~S_ISGID);
unlink(path); unlink(path);
assert(!(s.st_mode & S_ISUID));
assert(!(s.st_mode & S_ISGID));
} }
static void test_change_file_ownership() static void test_change_file_ownership()
@ -68,11 +69,10 @@ static void test_change_file_ownership()
struct stat s; struct stat s;
assert(fstat(fd, &s) != -1); assert(fstat(fd, &s) != -1);
close(fd); close(fd);
assert(s.st_mode & ~S_ISUID);
assert(s.st_mode & ~S_ISGID);
unlink(path); unlink(path);
assert(!(s.st_mode & S_ISUID));
assert(!(s.st_mode & S_ISGID));
} }
static void test_change_file_permissions() static void test_change_file_permissions()
@ -88,11 +88,36 @@ static void test_change_file_permissions()
struct stat s; struct stat s;
assert(fstat(fd, &s) != -1); assert(fstat(fd, &s) != -1);
close(fd); close(fd);
assert(s.st_mode & ~S_ISUID);
assert(s.st_mode & ~S_ISGID);
unlink(path); unlink(path);
assert(!(s.st_mode & S_ISUID));
assert(!(s.st_mode & S_ISGID));
}
static void test_change_file_location()
{
char path[] = "/tmp/suid.XXXXXX";
auto fd = mkstemp(path);
assert(fd != -1);
ftruncate(fd, 0);
assert(fchmod(fd, 06755) != -1);
auto suid_path = Core::File::read_link(String::formatted("/proc/{}/fd/{}", getpid(), fd));
assert(suid_path.characters());
auto new_path = String::formatted("{}.renamed", suid_path);
rename(suid_path.characters(), new_path.characters());
struct stat s;
assert(lstat(new_path.characters(), &s) != -1);
close(fd);
unlink(path);
// renamed file should retain set-uid/set-gid permissions
assert(s.st_mode & S_ISUID);
assert(s.st_mode & S_ISGID);
unlink(new_path.characters());
} }
int main() int main()
@ -106,6 +131,7 @@ int main()
RUNTEST(test_change_file_contents); RUNTEST(test_change_file_contents);
RUNTEST(test_change_file_ownership); RUNTEST(test_change_file_ownership);
RUNTEST(test_change_file_permissions); RUNTEST(test_change_file_permissions);
RUNTEST(test_change_file_location);
printf("PASS\n"); printf("PASS\n");
return 0; return 0;