RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-05-22 15:55:07 +00:00
Code Issues Activity Actions

WebDriver: Rename serialize_window_rect to serialize_rect

Browse source 
This won't only be used for "Window" rects.
This commit is contained in:
Timothy Flynn 2022-11-03 14:26:11 -04:00 • committed by Linus Groh
parent 995f3db384
commit a490bca29b
1 changed files with 5 additions and 5 deletions
Download patch file Download diff file Expand all files Collapse all files

10
Userland/Services/WebDriver/Session.cpp
View file

@ -289,7 +289,7 @@ ErrorOr<JsonValue, WebDriverError> Session::get_window_handles() const
return handles;
}
static JsonObject serialize_window_rect(Gfx::IntRect const& rect)
static JsonObject serialize_rect(Gfx::IntRect const& rect)
{
JsonObject serialized_rect = {};
serialized_rect.set("x", rect.x());
@ -309,7 +309,7 @@ ErrorOr<JsonValue, WebDriverError> Session::get_window_rect()
// FIXME: 2. Handle any user prompts and return its value if it is an error.
// 3. Return success with data set to the WindowRect object for the current top-level browsing context.
return serialize_window_rect(m_browser_connection->get_window_rect());
return serialize_rect(m_browser_connection->get_window_rect());
}
// 11.8.2 Set Window Rect, https://w3c.github.io/webdriver/#dfn-set-window-rect
@ -381,7 +381,7 @@ ErrorOr<JsonValue, WebDriverError> Session::set_window_rect(JsonValue const& pay
}
// 14. Return success with data set to the WindowRect object for the current top-level browsing context.
return serialize_window_rect(m_browser_connection->get_window_rect());
return serialize_rect(m_browser_connection->get_window_rect());
}
// 11.8.3 Maximize Window, https://w3c.github.io/webdriver/#dfn-maximize-window
@ -402,7 +402,7 @@ ErrorOr<JsonValue, WebDriverError> Session::maximize_window()
m_browser_connection->async_maximize_window();
// 7. Return success with data set to the WindowRect object for the current top-level browsing context.
return serialize_window_rect(m_browser_connection->get_window_rect());
return serialize_rect(m_browser_connection->get_window_rect());
}
// 11.8.4 Minimize Window, https://w3c.github.io/webdriver/#minimize-window
@ -420,7 +420,7 @@ ErrorOr<JsonValue, WebDriverError> Session::minimize_window()
m_browser_connection->async_minimize_window();
// 6. Return success with data set to the WindowRect object for the current top-level browsing context.
return serialize_window_rect(m_browser_connection->get_window_rect());
return serialize_rect(m_browser_connection->get_window_rect());
}
// https://w3c.github.io/webdriver/#dfn-get-or-create-a-web-element-reference